fix: use item gst details for tax amounts in transaction data #2487
+16
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljain112
force-pushed
the
fix-transaction-fdata
branch
from
8818a2c
to
a7d8fe1
Compare
ljain112
force-pushed
the
fix-transaction-fdata
branch
from
a7d8fe1
to
a8f3616
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2487 +/- ##
===========================================
- Coverage 61.41% 61.08% -0.33%
===========================================
Files 117 118 +1
Lines 11277 11331 +54
===========================================
- Hits 6926 6922 -4
- Misses 4351 4409 +58
... and 10 files with indirect coverage changes |
vorasmit
reviewed
Aug 13, 2024
| } | ||
| ) | ||
|
|
||
| def get_progressive_item_tax_amount(self, amount, tax_type): |
There was a problem hiding this comment.
This may be still needed. Can be implemented at Item GST Details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huly®: IC-2603