Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging #4

Merged
merged 15 commits into from
May 3, 2024
Merged

logging #4

merged 15 commits into from
May 3, 2024

Conversation

gabrielecalvo
Copy link
Collaborator

@gabrielecalvo gabrielecalvo commented May 2, 2024

Replacing printing with logging and introducing a global result_manager to handle bespoke warnings to track.

also fixed code to allow kelmarsh_example to work (issue with data already coming with timezone)

@gabrielecalvo gabrielecalvo requested a review from aclerc May 2, 2024 13:13
@gabrielecalvo gabrielecalvo marked this pull request as ready for review May 2, 2024 13:15
@aclerc
Copy link
Contributor

aclerc commented May 2, 2024

for some reason floatfmt=".1f" is not working anymore, it seems like the change to tablefmt="pretty" might be the cause but still looking...
image

@aclerc
Copy link
Contributor

aclerc commented May 2, 2024

for some reason floatfmt=".1f" is not working anymore, it seems like the change to tablefmt="pretty" might be the cause but still looking... image

found a fix, will just use "outline" instead of "pretty"

Copy link
Contributor

@aclerc aclerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gabrielecalvo !

@aclerc aclerc merged commit 05cbaf4 into main May 3, 2024
1 check passed
@aclerc aclerc deleted the logging branch May 3, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants