-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align template's npm script names with the ones in the installation guide #576
Align template's npm script names with the ones in the installation guide #576
Conversation
@cristianoc Writing this just in case you missed it. This PR should be merged too, to make the changes valid rescript-lang/rescript-project-template#10. |
That was too quick then. |
How about reverting it for now so we don't break anyone's experience of following the guide? |
done |
@cristianoc Is there somebody responsible for reviewing https://github.com/rescript-lang/rescript-project-template PRs? |
@cknitt who last updated it -- any thoughts? |
I have not contributed to that template yet, but I can review the PRs. Cleaning up that template fits in well with my https://github.com/rescript-lang/create-rescript-app initiative anyway. 🙂 |
Looks like it should be a replacement for |
@DZakh Yes, exactly, as the built-in templates / I have now approved all your PRs in https://github.com/rescript-lang/rescript-project-template. Happy to hear if you have any ideas for rescript-lang/create-rescript-app#11 BTW. |
The template changes were merged, so this PR needs to be re-reverted. |
Re-reverted. |
Related to rescript-lang/rescript-project-template#10