Enhancement: Add support for checks key in required_status_checks
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@localheinz is attempting to deploy a commit to the Probot Team on Vercel. A member of the Team first needs to authorize it. |
|
As far as I can tell, this already works out of the box, so in other words, this pull request only documents the deprecated changes. ❗ I have not tried to find out whether the GitHub API rejects requests where both |
localheinz
force-pushed
the
feature/checks
branch
from
d8670fa
to
80a6968
Compare
rogerluan
suggested changes
Oct 9, 2022
Comment on lines
+147
to
148
| # Required. Deprecated. The list of status checks to require in order to merge into this branch. If any of these checks have recently been set by a particular GitHub App, they will be required to come from that app in future for the branch to merge. Use checks instead of contexts for more fine-grained control. | ||
| contexts: [] |
There was a problem hiding this comment.
Suggested change
| # Required. Deprecated. The list of status checks to require in order to merge into this branch. If any of these checks have recently been set by a particular GitHub App, they will be required to come from that app in future for the branch to merge. Use checks instead of contexts for more fine-grained control. | |
| contexts: [] |
I'd just remove this entirely. It works, I tested. 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
checkskey inrequired_status_checks💁♂️ For reference, see https://docs.github.com/en/rest/reference/branches#update-branch-protection.
View rendered README.md