Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset global jumpList on unload #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hrjakobsen
Copy link

@hrjakobsen hrjakobsen commented Nov 30, 2022

This PR resets the jumpList that contains document references on unload. This fixes an issue where the extension would attempt to access out-of-range document data when switching between files.

To replicate bug in dev environment:

  1. Type (insert mode) module on first line of the Javascript editor
  2. Tick "html"
  3. Type (normal mode) /module
  4. Press n until last match is highlighted
  5. Until "html"
  6. Press n

@nightwing
Copy link
Collaborator

Perhaps we need a way to keep some kind of document id in the jumplist, or keep the jumplist locally, because as far as i can tell with this change destroying an editor by e.g. closing an unfocused tab, will clear the jumplist of the focused tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants