Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make feature types consistent #197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make feature types consistent #197

wants to merge 1 commit into from

Conversation

jasonLaster
Copy link
Contributor

We've gone back and forth a couple of times here because of a miscommunication.

I think this should simplify things considerably:

  1. BaseHub is the source of truth for whether a feature is an image or video
  2. BaseHub has the video id. Eventually it'll also have the video and the image as well. That's what we're doing on docs and it's simpler.
  3. The code has the minimal amount of code needed to support images that are in the repo.

@vercel Vercel
Copy link

vercel bot commented Apr 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 0:16am
replay ❌ Failed (Inspect) Apr 11, 2024 0:16am

callingmedic911
callingmedic911 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@callingmedic911 callingmedic911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callingmedic911 callingmedic911 callingmedic911 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonLaster @callingmedic911