fix(prometheus): making prometheus url optional instead of one time health check #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
commented
Mar 25, 2025
| let Ok(header_value) = HeaderValue::from_str(&self.prometheus_workspace_header) else { | ||
| warn!( | ||
| error!( |
There was a problem hiding this comment.
It must be an error since if the Prometheus URL was passed and we can't update, something is wrong.
nopestack
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the Prometheus URL config parameter optional and disables querying Prometheus if it's not provided, instead of the one-time health check during the bootstrap.
How Has This Been Tested?
Tested manually.
Due Diligence