Constrain old sail versions to omd<1.4 #14
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As you probably know, leaving it unconstrained can result in opam trying
to build sail with omd 2.0.0~alpha2, which ends up producing an error something
like:
```
File "latex.ml", line 226, characters 6-21:
226 | | Paragraph elems ->
^^^^^^^^^^^^^^^
Error: The constructor Paragraph expects 2 argument(s),
but is applied here to 1 argument(s)
```
... due to omd 2's revamp of the
AST (<ocaml-community/omd#234>).
Anyway, it turns out that opam can still end up picking sail 0.13 and
earlier, which (unlike version 0.14) don't yet have this constraint, and
so still fail fail to build in this manner.
I'm not really sure why sail 0.14 chose the constraint "omd<1.4", but in
the interest of monotonicity, I elected to apply the same one retroactively:
``` sh
opam admin add-constraint 'omd<1.4'
```
It may seem alarming to update existing packages in this way, but
apparently this is the state-of-the-art in opam repository
administration at the moment. (Meaning: nobody's managed to figure out
how to avoid needing to do it.)
Apparently, nothing too terrible happens as long as you restrict such
changes to tightening up version constraints, and don't do so in ways
that would prevent something that worked before from working now. Since
this change only excludes two versions of omd that currently
exist (2.0.0~alpha1 and 2.0.0~alpha2), which as we've seen don't work
for sail, we should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you probably know, leaving it unconstrained can result in opam trying
to build sail with omd 2.0.0~alpha2, which ends up producing an error something
like:
... due to omd 2's revamp of the
AST (ocaml-community/omd#234).
Anyway, it turns out that opam can still end up picking sail 0.13 and
earlier, which (unlike version 0.14) don't yet have this constraint, and
so still fail fail to build in this manner.
I'm not really sure why sail 0.14 chose the constraint "omd<1.4", but in
the interest of monotonicity, I elected to apply the same one retroactively:
opam admin add-constraint 'omd<1.4'It may seem alarming to update existing packages in this way, but
apparently this is the state-of-the-art in opam repository
administration at the moment. (Meaning: nobody's managed to figure out
how to avoid needing to do it.)
Apparently, nothing too terrible happens as long as you restrict such
changes to tightening up version constraints, and don't do so in ways
that would prevent something that worked before from working now. Since
this change only excludes two versions of omd that currently
exist (2.0.0
alpha1 and 2.0.0alpha2), which as we've seen don't workfor sail, we should be fine.