Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CN: Use mem_vip backend (fix #850) #915

Merged
merged 3 commits into from
Mar 7, 2025
Merged

CN: Use mem_vip backend (fix #850) #915

merged 3 commits into from
Mar 7, 2025

Conversation

dc-mak
Copy link
Collaborator

@dc-mak dc-mak commented Mar 6, 2025

No description provided.

@dc-mak dc-mak requested review from kmemarian and cp526 March 6, 2025 16:01
@kmemarian
Copy link
Collaborator

This needs a few tweaks to vip/common.ml to sync up with the concrete and ocaml_implementation. Which I can do shortly.

kmemarian
kmemarian approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@kmemarian kmemarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the cn-coq failure that I don't understand (@vzaliva ?), this looks good to me.

@vzaliva
Copy link
Member

vzaliva commented Mar 7, 2025 •
edited
Loading

To fix Coq part, we need to adjust pp_pointer_value_for_coq to print constructors with Mem prefix. E.g:

| PVnull -> !^"PVnull"

should be

| PVnull -> !^"Mem.PVnull"

That should fix CI error.

@dc-mak dc-mak marked this pull request as ready for review March 7, 2025 13:41
@dc-mak
Copy link
Collaborator Author

dc-mak commented Mar 7, 2025

Thanks for the team effort! @kmemarian @vzaliva if good to go feel free to squash and merge in.

@kmemarian kmemarian merged commit b232343 into rems-project:master Mar 7, 2025
5 checks passed
@dc-mak dc-mak deleted the cn-use-mem-vip branch March 7, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmemarian kmemarian kmemarian approved these changes

@cp526 cp526 Awaiting requested review from cp526

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dc-mak @kmemarian @vzaliva