Add eslint disable support #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captbaritone
reviewed
Feb 5, 2021
README.md
Outdated
| }` | ||
| ``` | ||
|
|
||
| Note that only this form of suppression works. Inline disables don't currently work until graphql-js provides support for parsing Comment nodes in their AST. |
There was a problem hiding this comment.
I'm not sure I understand what you mean by "inline disables". To me eslint-disable-next-line is a type of inline disable.
There was a problem hiding this comment.
Hmm, I was referring to the eslint suppression where the comment is on the same line as the offending ast node to be "inline". I guess I could make the readme more specific
There was a problem hiding this comment.
Ah, I get it now. Thanks for the update!
poteto
force-pushed
the
add-eslint-disable-support
branch
from
7ec2649 to
d26e588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to suppress eslint reporting within graphql tags:
Note that only the
eslint-disable-next-lineform of suppression works.eslint-disable-linedoesn't currently work until graphql-js provides support for parsing Comment nodes in their AST.