Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
I've come to an error trying to stringify an empty string when
fragment: true
is enabled.It fails here because
hast-util-to-dom
returns anXmlDocument
withdocumentElement: null
. So there is 2 solutions to me, either :XmlDocument
withdocumenElement: null
inrehype-dom-stringify
DocumentFragment
inhast-util-to-dom
even if there is no child nodesI have done solution 1 in this PR along with a failing test. If it you think solution 2 is more appropriate, I can make a PR to
hast-util-to-dom
.