Add a partial update User endpoint #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had broken the user login part of rapidoc a while back. This fixes it
jhodapp
reviewed
Mar 4, 2025
There was a problem hiding this comment.
@calebbourg Looks really great, I like the new UpdateMap pattern and IntoUpdateMap trait a lot.
One question I'm curious for your thoughts on inline.
| ) -> Result<users::Model, Error> { | ||
| let existing_user = find_by_id(db, user_id).await?; | ||
| let active_model = existing_user.into_active_model(); | ||
| Ok(mutate::update::<users::ActiveModel, users::Column>( |
There was a problem hiding this comment.
Nice, we're consistent in our verbiage of mutate in both the backend here and the frontend with my recent API refactoring work. And they hold very similar meanings. This is a very good thing.
| pub github_profile_url: Option<String>, | ||
| } | ||
|
|
||
| impl IntoUpdateMap for UpdateUserParams { |
There was a problem hiding this comment.
I love this pattern for updating just the right fields - it's extremely clean, easy to understand and effective.
jhodapp
approved these changes
Mar 4, 2025
github-project-automation
bot
moved this from Review
to ✅ Done
in Refactor Coaching Platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a pattern for providing partial updates to database tables via our API.
By partial updates I mean that we are able to modify a subset of columns for any given table without having to provide values for the the other columns. The pattern is somewhat based on the pattern for filtering queries as introduced in #102
Note: This new endpoint assumes that the user being updated will always be the current user (as noted inline in comments). At some point we will likely want a user to be able to make updates to another user. We can decide how the code diverges at that point when we know more about how we want that to work.
Changes
updatefunctionPUT /usersupdate endpointTesting Strategy
I was able to test partially updating a user in Rapidoc
Coming Up