Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slugify organization names #107

Merged
merged 5 commits into from
Mar 6, 2025
Merged

Slugify organization names #107

merged 5 commits into from
Mar 6, 2025

Conversation

calebbourg
Copy link
Collaborator

@calebbourg calebbourg commented Mar 4, 2025

Description

This PR generates slug values on the BE for Coaching Relationships and Organizations.

I also required users to have a first_name and last_name. This simplified the slug generation for Coaching Relationships and, I think, makes sense as a requirement.

Changes

  • Adds slug creation for Coaching Relationships and Organizations
  • Make first_name and last_name required for users

@jhodapp jhodapp added the enhancement Improves existing functionality or feature label Mar 5, 2025
@jhodapp jhodapp added this to the 1.0-beta1 milestone Mar 5, 2025
@calebbourg calebbourg changed the base branch from main to users_and_coaching_sessions March 5, 2025 22:49
@calebbourg calebbourg changed the base branch from users_and_coaching_sessions to main March 5, 2025 22:51
@calebbourg calebbourg requested a review from jhodapp March 5, 2025 22:56
@calebbourg calebbourg marked this pull request as ready for review March 5, 2025 22:56
Copy link
Member

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.


let organization_active_model: ActiveModel = ActiveModel {
logo: Set(organization_model.logo),
name: Set(organization_model.name),
name: Set(name.clone()),
slug: Set(slugify!(name.as_str())),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, so easy! Love it.

@jhodapp jhodapp changed the title slugify organization names Slugify organization names Mar 6, 2025
@calebbourg calebbourg merged commit 92b19df into main Mar 6, 2025
4 checks passed
@calebbourg calebbourg deleted the add_slugify branch March 6, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants