Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-883 Support for automated Go mod updates #243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DOC-883 Support for automated Go mod updates #243

wants to merge 2 commits into from

Conversation

JakeSCahill
Copy link
Contributor

No description provided.

@JakeSCahill JakeSCahill requested a review from Deflaimun January 16, 2025 16:23
@netlify Netlify
Copy link

netlify bot commented Jan 16, 2025 •
edited
Loading

✅ Deploy Preview for docs-ui ready!

Name Link
🔨 Latest commit 4f07941
🔍 Latest deploy log https://app.netlify.com/sites/docs-ui/deploys/678b5441dc3fea00088d1a32
😎 Deploy Preview https://deploy-preview-243--docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Deflaimun Deflaimun requested a review from r-vasquez January 16, 2025 16:27
@Deflaimun
Copy link
Contributor

Adding @r-vasquez as a reviewer, as Go specialist.

@JakeSCahill JakeSCahill changed the title DOC-833 Support for automated Go mod updates DOC-883 Support for automated Go mod updates Jan 17, 2025
@JakeSCahill JakeSCahill mentioned this pull request Jan 17, 2025
Open
r-vasquez
r-vasquez reviewed Jan 17, 2025
View reviewed changes
Copy link

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small comment. I would also leave a small quick document (a readme maybe?) on how to trigger this action to update the dependencies and create the PR

.github/workflows/update-go-mod.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-vasquez r-vasquez r-vasquez left review comments

@Deflaimun Deflaimun Awaiting requested review from Deflaimun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeSCahill @Deflaimun @r-vasquez