Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dialect 2 on default #3213

Merged
merged 6 commits into from
Mar 13, 2025
Merged

Enable dialect 2 on default #3213

merged 6 commits into from
Mar 13, 2025

Conversation

ofekshenawa
Copy link
Collaborator

No description provided.

@ofekshenawa ofekshenawa marked this pull request as ready for review January 15, 2025 10:44
@ofekshenawa ofekshenawa changed the title Enabling dialect 2 on default Enable dialect 2 on default Jan 15, 2025
@ofekshenawa ofekshenawa force-pushed the enabling-dialect-2-on-default branch from 57317f9 to 85b8301 Compare February 19, 2025 16:22
@ndyakov
Copy link
Collaborator

ndyakov commented Feb 20, 2025

@ofekshenawa since this is a breaking change, let's add note in the README (bolded) that the default dialect for search is 2

@ndyakov ndyakov self-requested a review February 20, 2025 14:28
@ofekshenawa ofekshenawa force-pushed the enabling-dialect-2-on-default branch from 944c4b9 to 63cf646 Compare March 13, 2025 08:47
@ndyakov ndyakov merged commit 555a41e into master Mar 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants