fix: Fixed issue with context cancelled error leading to connection spikes on Primary instances #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EXPEbdodla
force-pushed
the
connection_issue
branch
2 times, most recently
from
06a4de2 to
c6d0fff
Compare
EXPEbdodla
force-pushed
the
connection_issue
branch
from
c6d0fff to
de69b49
Compare
|
can I get a review on this PR please? Thank you. |
|
@EXPEbdodla looking into it |
|
Looks related to #3282 |
fishy
reviewed
Feb 20, 2025
|
@EXPEbdodla let's add a test for this change and we are good to go with the pr. |
Thanks @ndyakov . I'll look into adding tests for this. |
added 2 commits
February 21, 2025 16:33
EXPEbdodla
force-pushed
the
connection_issue
branch
from
575ef70 to
6559130
Compare
@ndyakov Added tests to this PR. |
ndyakov
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: After upgrading from 9.5.1 to 9.7.0, we noticed the spikes in connections to Master/ Primary nodes and also reads are happening from Master nodes. Also noticed increase in pool_conn_total_current metrics.
Environment: AWS Cloud, Elasticache Redis with Cluster Mode
Cause: After debugging, we noticed that nodes are marked as failed when the
context.Cancellederror is raisedgo-redis/osscluster.go
Line 1324 in 930d904
We tested this by deploying the change from my Fork and noticed improvements. Elasticache Cluster Current Connections Screenshot:
FYI: My first PR to go-redis. Happy to fix if any concerns.