Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Allow testing PRs targetting release branches #83

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 3, 2025

Description of the change

PRs (like #80) targetting release branches fail because the linter is configured to detect Chart changes compared to the main branch.

Existing or Associated Issue(s)

https://github.com/redhat-developer/rhdh-chart/actions/runs/13111112811/job/36575072460?pr=80

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@openshift-ci openshift-ci bot requested review from coreydaley and tumido February 3, 2025 10:38
Copy link

sonarqubecloud bot commented Feb 3, 2025

@rm3l
Copy link
Member Author

rm3l commented Feb 3, 2025

/cherry-pick release-1.3
/cherry-pick release-1.4

@openshift-cherrypick-robot

@rm3l: once the present PR merges, I will cherry-pick it on top of release-1.3, release-1.4 in new PRs and assign them to you.

In response to this:

/cherry-pick release-1.3
/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rm3l rm3l merged commit 7aeb753 into redhat-developer:main Feb 3, 2025
5 of 6 checks passed
@rm3l rm3l deleted the ci_allow_testing_prs_targetting_release_branches branch February 3, 2025 10:41
@rm3l rm3l added the lgtm label Feb 3, 2025
@openshift-cherrypick-robot

@rm3l: new pull request created: #84

In response to this:

/cherry-pick release-1.3
/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@rm3l: new pull request created: #85

In response to this:

/cherry-pick release-1.3
/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants