Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use b&w icon as dark to have better contrast in status bar #439

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dgolovin
Copy link
Collaborator

To have a good contrast icon for status bar b&w button added for dark theme. This fixes status bar issue, but now the same b&w icon used for dashboard and resources page as well

image

image

@dgolovin dgolovin requested a review from a team as a code owner March 18, 2025 06:04
@dgolovin dgolovin requested review from benoitf, cdrage and gastoner March 18, 2025 06:04
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: how the file is being added to the OCI image of the extension ?

@dgolovin dgolovin requested a review from benoitf March 18, 2025 16:49
@dgolovin
Copy link
Collaborator Author

dgolovin commented Mar 18, 2025

question: how the file is being added to the OCI image of the extension ?

Fixed by including it into .extfiles file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants