Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rsa-pkcs-openssl test. #322

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Add rsa-pkcs-openssl test. #322

merged 2 commits into from
Dec 13, 2023

Conversation

tmds
Copy link
Member

@tmds tmds commented Dec 13, 2023

@tmds tmds requested review from omajid and nicrowe00 December 13, 2023 08:33
tomato42
tomato42 suggested changes Dec 13, 2023
View reviewed changes
Copy link

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since implicit rejection algorithm is deterministic, the test should expect specific message returned for a given static ciphertext and static key.

@tmds
Copy link
Member Author

tmds commented Dec 13, 2023

Since implicit rejection algorithm is deterministic, the test should expect specific message returned for a given static ciphertext and static key.

I've updated the test.

tomato42
tomato42 approved these changes Dec 13, 2023
View reviewed changes
Copy link

@tomato42 tomato42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified to be an invalid ciphertext and the synthetic message to match one expected from the algorithm specified in https://datatracker.ietf.org/doc/html/draft-kario-rsa-guidance-02#name-depadding

Looks good!

@tmds tmds merged commit 354d765 into redhat-developer:main Dec 13, 2023
12 of 18 checks passed
@tmds
Copy link
Member Author

tmds commented Dec 13, 2023

Thanks for reviewing, @nicrowe00 and @tomato42!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomato42 tomato42 tomato42 approved these changes

@nicrowe00 nicrowe00 nicrowe00 approved these changes

@omajid omajid Awaiting requested review from omajid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmds @tomato42 @nicrowe00