Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reuse templates #465

Conversation

Roming22
Copy link
Member

@Roming22 Roming22 commented Feb 14, 2025

cf RHTAPINST-50

Link identical template files to a single instance: helpers.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

@Roming22 Roming22 force-pushed the chore/common-templates-refactor branch from eac01bc to 7bbbf7a Compare February 14, 2025 20:09
@Roming22
Copy link
Member Author

/retest

@Roming22 Roming22 force-pushed the chore/common-templates-refactor branch from 7bbbf7a to 3b72021 Compare February 17, 2025 19:00
@openshift-ci openshift-ci bot removed the lgtm label Feb 17, 2025
@Roming22
Copy link
Member Author

/retest

@Roming22 Roming22 force-pushed the chore/common-templates-refactor branch 2 times, most recently from e79bde0 to 73807fc Compare February 18, 2025 03:29
cf RHTAPINST-50

Link identical template files to a single instance: helpers.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Roming22 Roming22 force-pushed the chore/common-templates-refactor branch from 73807fc to cbe26fd Compare February 18, 2025 03:33
Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👍

/lgtm

Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingyzhuang, otaviof, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9784e3b into redhat-appstudio:main Feb 18, 2025
11 checks passed
@Roming22 Roming22 deleted the chore/common-templates-refactor branch February 18, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants