Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed acs_registry_integratio function from install.sh #464

Merged

Conversation

xinredhat
Copy link
Member

RTHAP-CLI already implemented it in PR #413, we removed the duplicated setup integration-tests/scripts/install.sh script

@openshift-ci openshift-ci bot requested review from otaviof and Roming22 February 14, 2025 05:54
Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, Roming22, xinredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Roming22 Roming22 force-pushed the remove-acs_registry_integratio branch from 605ed1f to a0fac79 Compare February 14, 2025 15:40
@openshift-ci openshift-ci bot removed the lgtm label Feb 14, 2025
Copy link

openshift-ci bot commented Feb 14, 2025

New changes are detected. LGTM label has been removed.

@Roming22 Roming22 force-pushed the remove-acs_registry_integratio branch from a0fac79 to 1f3a9d6 Compare February 14, 2025 18:08
@konflux-ci-qe-bot
Copy link

@xinredhat: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
e2e-4.16-t2jrp Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.16-t2jrp

Test results analysis

<not enabled>

@Roming22
Copy link
Member

Force merging as CI is unstable and tests passed on 4.17

@Roming22 Roming22 merged commit 2622a06 into redhat-appstudio:main Feb 14, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants