Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve hack scripts #463

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

Roming22
Copy link
Member

  • reset.sh: add '--all' flag
  • reset.sh: remove the '-i dh' option as DH can now be reset with '-n rhtap-dh'
  • reset.sh: delete PVCs on namespace deletion
  • fix a small issue with the ENVFILE var

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

- reset.sh: add '--all' flag
- reset.sh: remove the '-i dh' option as DH can now be reset with
  '-n rhtap-dh'
- reset.sh: delete PVCs on namespace deletion
- fix a small issue with the ENVFILE var

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Roming22
Copy link
Member Author

@otaviof @lingyzhuang This PR doesn't need the CI to be green to be merged.

@Roming22
Copy link
Member Author

/retest

@konflux-ci-qe-bot
Copy link

@Roming22: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
e2e-4.17-7r9l6 Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.17-7r9l6

Test results analysis

<not enabled>

Copy link

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingyzhuang, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Roming22 Roming22 merged commit 8809324 into redhat-appstudio:main Feb 14, 2025
9 of 11 checks passed
@Roming22 Roming22 deleted the fix/hack branch February 14, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants