Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mandatory flag --group to gitlab integration #462

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

lingyzhuang
Copy link
Contributor

Add a new flag --group to gitlab integration, and it is mandatory.

@openshift-ci openshift-ci bot requested review from rhopp and Roming22 February 13, 2025 13:15
@lingyzhuang lingyzhuang requested a review from otaviof February 13, 2025 13:16
@@ -17,6 +17,7 @@ export GITLAB__TOKEN=
# When using gitlab as auth provider(auth_config="github"), you also need to set the following values
export GITLAB__APP__ID=
export GITLAB__APP_SECRET=
export GITLAB__APP_GROUP=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GITLAB__GROUP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, should be GITLAB__GROUP. Updated.

Copy link

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingyzhuang, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Roming22 Roming22 removed the lgtm label Feb 13, 2025
@lingyzhuang lingyzhuang force-pushed the add-gitlab-group-flag branch from f3cdb64 to 7004d35 Compare February 14, 2025 02:43
@lingyzhuang
Copy link
Contributor Author

/retest

Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the gofmt comment, the rest looks fine!

@Roming22 Roming22 force-pushed the add-gitlab-group-flag branch from ba3cb7e to 95d6ffc Compare February 14, 2025 15:41
@konflux-ci-qe-bot
Copy link

@lingyzhuang: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
e2e-4.16-ckxv9 Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.16-ckxv9

Test results analysis

<not enabled>

@Roming22
Copy link
Member

Force merging as the CI is unstabled but passed on OCP 4.17.

@Roming22 Roming22 merged commit c6e6f59 into redhat-appstudio:main Feb 14, 2025
9 of 11 checks passed
Roming22 added a commit to Roming22/rhtap-cli that referenced this pull request Feb 14, 2025
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@lingyzhuang lingyzhuang deleted the add-gitlab-group-flag branch February 16, 2025 02:44
Roming22 added a commit that referenced this pull request Feb 17, 2025
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants