-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a mandatory flag --group to gitlab integration #462
Add a mandatory flag --group to gitlab integration #462
Conversation
integration-tests/scripts/.ci-env
Outdated
@@ -17,6 +17,7 @@ export GITLAB__TOKEN= | |||
# When using gitlab as auth provider(auth_config="github"), you also need to set the following values | |||
export GITLAB__APP__ID= | |||
export GITLAB__APP_SECRET= | |||
export GITLAB__APP_GROUP= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GITLAB__GROUP
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, should be GITLAB__GROUP
. Updated.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lingyzhuang, Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f3cdb64
to
7004d35
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the gofmt
comment, the rest looks fine!
ba3cb7e
to
95d6ffc
Compare
|
@lingyzhuang: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.16-ckxv9 Test results analysis<not enabled> |
Force merging as the CI is unstabled but passed on OCP 4.17. |
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Add a new flag --group to gitlab integration, and it is mandatory.