Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: give CI workloads their own namespace #459

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Roming22
Copy link
Member

There is no reason for the development application to run in a namespace with the extra secrets needed by the ci.

This split provides better segregation of information and makes the development namespace identical to the other deployment namespaces in term of configuration.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Copy link
Member

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, but someone with more in-depth knowledge should probably review too.

Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@otaviof
Copy link
Collaborator

otaviof commented Feb 13, 2025

/retest

Copy link

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva, lingyzhuang, otaviof, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Roming22,lcarva,otaviof]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

There is no reason for the development application to run
in a namespace with the extra secrets needed by the ci.

This split provides better segregation of information and
makes the development namespace identical to the other
deployment namespaces in term of configuration.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Copy link

openshift-ci bot commented Feb 13, 2025

New changes are detected. LGTM label has been removed.

@Roming22
Copy link
Member Author

CI is not going to pass because of the dependency on redhat-appstudio/rhtap-e2e#227.
But I'd like to see the install step being successful before force merging. Alas the CI is unstable at the moment.

@Roming22
Copy link
Member Author

/retest

@konflux-ci-qe-bot
Copy link

@Roming22: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
e2e-4.16-h7gxl Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.16-h7gxl

Test results analysis

<not enabled>

@Roming22
Copy link
Member Author

@Roming22 Roming22 merged commit dfb5a19 into redhat-appstudio:main Feb 14, 2025
9 of 11 checks passed
@Roming22 Roming22 deleted the feat/app-ci-ns branch February 14, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants