-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: give CI workloads their own namespace #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, but someone with more in-depth knowledge should probably review too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcarva, lingyzhuang, otaviof, Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is no reason for the development application to run in a namespace with the extra secrets needed by the ci. This split provides better segregation of information and makes the development namespace identical to the other deployment namespaces in term of configuration. rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
015082f
to
8a622bf
Compare
New changes are detected. LGTM label has been removed. |
|
CI is not going to pass because of the dependency on redhat-appstudio/rhtap-e2e#227. |
/retest |
@Roming22: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.16-h7gxl Test results analysis<not enabled> |
There is no reason for the development application to run in a namespace with the extra secrets needed by the ci.
This split provides better segregation of information and makes the development namespace identical to the other deployment namespaces in term of configuration.
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED