Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor improvement to the repository #451

Merged

Conversation

Roming22
Copy link
Member

@Roming22 Roming22 commented Feb 7, 2025

  • Add README.md to all charts
  • reorganize rhtap-backing-services
  • removed a few unused resources

cf RHTAP-4361

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

@Roming22 Roming22 requested a review from otaviof February 7, 2025 20:53
@openshift-ci openshift-ci bot added the approved label Feb 7, 2025
- Add README.md to all charts
- reorganize rhtap-backing-services
- removed a few unused resources

cf RHTAP-4361

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Roming22 Roming22 force-pushed the chore/minor-improvements branch from 5c96068 to f5fdd4f Compare February 7, 2025 21:17
Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👍

/lgtm

Copy link

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@otaviof
Copy link
Collaborator

otaviof commented Feb 10, 2025

/retest

2 similar comments
@Roming22
Copy link
Member Author

/retest

@Roming22
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 3f6e6c6 into redhat-appstudio:main Feb 11, 2025
11 checks passed
@Roming22 Roming22 deleted the chore/minor-improvements branch February 11, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants