Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reuse templates #432

Merged
merged 1 commit into from
Feb 17, 2025
Merged

chore: reuse templates #432

merged 1 commit into from
Feb 17, 2025

Conversation

Roming22
Copy link
Member

@Roming22 Roming22 commented Feb 3, 2025 •
edited by openshift-ci bot
Loading

cf RHTAPINST-50

Link identical template files to a single instance: service-account.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

@Roming22 Roming22 requested a review from otaviof February 3, 2025 21:51
@openshift-ci openshift-ci bot requested review from jkopriva and prietyc123 February 3, 2025 21:51
@openshift-ci openshift-ci bot added the approved label Feb 3, 2025
otaviof
otaviof approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, @Roming22! Thanks.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 4, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Roming22
Copy link
Member Author

Roming22 commented Feb 4, 2025

/retest

4 similar comments
@Roming22
Copy link
Member Author

Roming22 commented Feb 4, 2025

/retest

@Roming22
Copy link
Member Author

Roming22 commented Feb 4, 2025

/retest

@Roming22
Copy link
Member Author

Roming22 commented Feb 4, 2025

/retest

@Roming22
Copy link
Member Author

Roming22 commented Feb 4, 2025

/retest

@openshift-ci openshift-ci bot removed the lgtm label Feb 5, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 5, 2025

New changes are detected. LGTM label has been removed.

@Roming22
Copy link
Member Author

Roming22 commented Feb 5, 2025

/retest

1 similar comment
@xinredhat
Copy link
Member

/retest

@xinredhat
Copy link
Member

xinredhat commented Feb 6, 2025 •
edited
Loading

it failed at rhtap-install task and reported error

Error: install failed: template: rhtap-acs-test/templates/service-account.yaml:2:4: executing "rhtap-acs-test/templates/service-account.yaml" at <include "common.serviceAccount" .>: error calling include: template: no template "common.serviceAccount" associated with template "gotpl"

@Roming22 Roming22 force-pushed the chore/common-templates branch from 54095ac to dac87f1 Compare February 6, 2025 16:33
@Roming22
Copy link
Member Author

Roming22 commented Feb 7, 2025

/retest

@Roming22 Roming22 force-pushed the chore/common-templates branch from dac87f1 to 66acef0 Compare February 10, 2025 13:37
@Roming22
Copy link
Member Author

/retest

@Roming22 Roming22 force-pushed the chore/common-templates branch from 66acef0 to e03d560 Compare February 11, 2025 19:24
@Roming22
Copy link
Member Author

/retest

@Roming22 Roming22 force-pushed the chore/common-templates branch 3 times, most recently from 4102342 to 23a1e24 Compare February 14, 2025 20:22
@Roming22
chore: reuse templates
345015d 
cf RHTAPINST-50

Link identical template files to a single instance: service-account.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Roming22 Roming22 force-pushed the chore/common-templates branch from 23a1e24 to 345015d Compare February 17, 2025 15:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Roming22
Copy link
Member Author

/retest

@konflux-ci-qe-bot
Copy link

@Roming22: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
e2e-4.16-h57gg Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.16-h57gg

Test results analysis

<not enabled>

@Roming22
Copy link
Member Author

Force merging as CI is unstable and tests were successful on 4.17.

@Roming22 Roming22 merged commit 2a1a741 into redhat-appstudio:main Feb 17, 2025
9 of 11 checks passed
@Roming22 Roming22 deleted the chore/common-templates branch February 17, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviof otaviof otaviof approved these changes

@jkopriva jkopriva Awaiting requested review from jkopriva

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees

@otaviof otaviof

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Roming22 @xinredhat @konflux-ci-qe-bot @otaviof