Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move ACS deployment test #430

Merged

Conversation

Roming22
Copy link
Member

@Roming22 Roming22 commented Feb 3, 2025

This change should improve the install time by deferring the validation of ACS towards the end of the process.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

This change should improve the install time by deferring
the validation of ACS towards the end of the process.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Roming22 Roming22 requested review from otaviof and jkopriva February 3, 2025 14:37
@openshift-ci openshift-ci bot requested review from prietyc123 and rhopp February 3, 2025 14:37
@openshift-ci openshift-ci bot added the approved label Feb 3, 2025
Copy link

sonarqubecloud bot commented Feb 3, 2025

Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Roming22
Copy link
Member Author

Roming22 commented Feb 3, 2025

/retest

1 similar comment
@Roming22
Copy link
Member Author

Roming22 commented Feb 3, 2025

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 67ce49a into redhat-appstudio:main Feb 3, 2025
11 checks passed
@Roming22 Roming22 deleted the feat/acs/validation branch February 11, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants