Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Cloudability's metrics-agent to stage-p01 #4428

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

filariow
Copy link
Member

This PR introduces an ApplicationSet for Cloudability's metrics-agent. The Agent is installed via it's Helm
Chart
and it will be initially deployed only in cluster stage-p01.

@filariow
Copy link
Member Author

/hold

@manish-jangra
Copy link
Contributor

I think, we should also have a kustomisation.yaml in components/cloudability-metrics-agent/staging/stone-stage-p01 directory pointing to values file.

@filariow
Copy link
Member Author

filariow commented Sep 2, 2024

I think, we should also have a kustomisation.yaml in components/cloudability-metrics-agent/staging/stone-stage-p01 directory pointing to values file.

I took inspiration from components/tracing/otel-collector/production.
The kustomization.yaml file there is not referencing the values.yaml file, so I thought it's not needed here either.

Also, given that the path field is not used in the ref-source, this should not build what's in the folder so it seems to me it should be fine (cf. https://argo-cd.readthedocs.io/en/stable/user-guide/multiple_sources/#helm-value-files-from-external-git-repository). WDYT?

@manish-jangra
Copy link
Contributor

/lgtm

@manish-jangra
Copy link
Contributor

@filariow lets create the the directory structure like other components

  • base
  • staging
  • production

will be easier to maintain configuration for different configurations for different overlays.

This commit introduces an ApplicationSet for [Cloudability's
metrics-agent](https://github.com/cloudability/metrics-agent/). The
Agent is installed via [it's Helm
Chart](https://github.com/cloudability/metrics-agent/tree/master?tab=readme-ov-file#deploying-with-helm)
and it will be initially deployed only in cluster stage-p01.
Signed-off-by: Francesco Ilario <[email protected]>
@manish-jangra
Copy link
Contributor

LGTM

@manish-jangra
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2024
deletion is already inherited from ../konflux-public-staging

Signed-off-by: Francesco Ilario <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Sep 11, 2024
Copy link

openshift-ci bot commented Sep 11, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Sep 11, 2024

@filariow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests 6451b90 link false /test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, manish-jangra, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ralphbean
Copy link
Member

@filariow this one needs a rebase and conflict resolution for tide to accept it.

@filariow
Copy link
Member Author

thanks @ralphbean, I'm waiting for cloudability's team to guarantee compatibility with OpenShift 4.15 and 4.16 (cloudability/metrics-agent#270). I'll move this PR to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants