-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Cloudability's metrics-agent to stage-p01 #4428
base: main
Are you sure you want to change the base?
Conversation
/hold |
...se/all-clusters/infra-deployments/cloudability-metrics-agent/cloudability-metrics-agent.yaml
Show resolved
Hide resolved
I think, we should also have a |
I took inspiration from components/tracing/otel-collector/production. Also, given that the |
771183f
to
4d0ba41
Compare
/lgtm |
@filariow lets create the the directory structure like other components
will be easier to maintain configuration for different configurations for different overlays. |
This commit introduces an ApplicationSet for [Cloudability's metrics-agent](https://github.com/cloudability/metrics-agent/). The Agent is installed via [it's Helm Chart](https://github.com/cloudability/metrics-agent/tree/master?tab=readme-ov-file#deploying-with-helm) and it will be initially deployed only in cluster stage-p01.
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
4d0ba41
to
31a048f
Compare
LGTM |
/lgtm |
deletion is already inherited from ../konflux-public-staging Signed-off-by: Francesco Ilario <[email protected]>
New changes are detected. LGTM label has been removed. |
@filariow: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow, manish-jangra, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@filariow this one needs a rebase and conflict resolution for tide to accept it. |
thanks @ralphbean, I'm waiting for cloudability's team to guarantee compatibility with OpenShift 4.15 and 4.16 (cloudability/metrics-agent#270). I'll move this PR to draft. |
This PR introduces an ApplicationSet for Cloudability's metrics-agent. The Agent is installed via it's Helm
Chart and it will be initially deployed only in cluster stage-p01.