-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFBUGS-1798: Shorten Volsync Job Name if exceeds 63 characters #469
base: release-4.18
Are you sure you want to change the base?
DFBUGS-1798: Shorten Volsync Job Name if exceeds 63 characters #469
Conversation
Signed-off-by: Elena Gershkovich <[email protected]> (cherry picked from commit 0d7dce1)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ELENAGER The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ELENAGER: This pull request references [Jira Issue DFBUGS-513](https://issues.redhat.com//browse/DFBUGS-513), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ELENAGER: This pull request references [Jira Issue DFBUGS-1798](https://issues.redhat.com//browse/DFBUGS-1798), which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes: https://issues.redhat.com/browse/DFBUGS-513
Also related to: backube/volsync#1470
The problem:
When replicating a Protected Application volumes via Volsync within the context of ACM Disaster recovery/Enroll Application/Discovered Application, it appears Volsync pre-pends "volsync-" when generating replicated PVC and "volsync-rsync-tls-src-" when generating Volsync Job/Pod names. The additional characters result in the error/failure within the corresponding ReplicationSource CR.
The solution:
Shorten PVC name in the job/service name
Signed-off-by: Elena Gershkovich [email protected]
(cherry picked from commit 0d7dce1)