Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a operator scaler controller to add dynamic watches on CRs and scale operators #529

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

create a operator scaler controller to add dynamic watches on CRs and scale operators #529

wants to merge 3 commits into from
+390 −1

Conversation

iamniting
Copy link
Member

Signed-off-by: Nitin Goyal [email protected]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@iamniting iamniting force-pushed the watch-crds branch 11 times, most recently from 1f10e0b to 89fb155 Compare February 26, 2025 10:55
leelavg
leelavg reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will review again after some of the comments are addressed.

@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@iamniting iamniting force-pushed the watch-crds branch 3 times, most recently from c697e53 to cb7d54f Compare March 3, 2025 08:46
@iamniting iamniting requested a review from leelavg March 3, 2025 08:52
@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@iamniting iamniting force-pushed the watch-crds branch 6 times, most recently from 04e9cb4 to 6076f63 Compare March 4, 2025 07:36
@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@iamniting iamniting force-pushed the watch-crds branch 2 times, most recently from 198911f to 68daff8 Compare March 5, 2025 08:44
@iamniting iamniting changed the title create a scaler controller to watch and trigger the events on CR creation create a operator scaler controller to add dynamic watches on CRs and scale operators Mar 5, 2025
@iamniting iamniting force-pushed the watch-crds branch 3 times, most recently from 7bec5da to fd7001c Compare March 10, 2025 12:11
@iamniting iamniting requested a review from nb-ohad March 10, 2025 12:16
nb-ohad
nb-ohad requested changes Mar 10, 2025
View reviewed changes
@iamniting
Copy link
Member Author

/hold for testing

@nb-ohad
Copy link

nb-ohad commented Mar 10, 2025

/LGTM

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Mar 10, 2025
@nb-ohad
Copy link

nb-ohad commented Mar 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamniting
Copy link
Member Author

Things are working as expected, I am removing the hold
/unhold

@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

7 similar comments
@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2025

@iamniting: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odf-operator-e2e-aws e8a7532 link true /test odf-operator-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nb-ohad nb-ohad nb-ohad requested changes

@leelavg leelavg Awaiting requested review from leelavg

Assignees

@nb-ohad nb-ohad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamniting @nb-ohad @leelavg @openshift-merge-robot