fix: added Rack info for the topology details screen #946
Conversation
debjyoti-pandit
changed the title
|
@debjyoti-pandit: This pull request references Bugzilla bug 2214023, which is valid. No validations were run on this bugNo GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @bipuladh |
|
LGTM (but we are now maintaining |
True, should I refactor it in this PR itself only? |
yup... |
|
plz fix the build tests... |
debjyoti-pandit
force-pushed
the
Bug-2214023
branch
from
b2b6eea
to
a5fa206
Compare
|
update the PR title correctly as per the guidelines... |
debjyoti-pandit
force-pushed
the
Bug-2214023
branch
from
a5fa206
to
26e92b4
Compare
debjyoti-pandit
changed the title
|
@debjyoti-pandit: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
debjyoti-pandit
changed the title
|
/test odf-console-e2e-aws |
|
squash the commits... |
debjyoti-pandit
force-pushed
the
Bug-2214023
branch
from
d23d737
to
b78efa4
Compare
debjyoti-pandit
force-pushed
the
Bug-2214023
branch
from
b78efa4
to
f0dafbe
Compare
|
/test odf-console-e2e-aws |
|
/cherry-pick release-4.14-compatibility |
|
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.14-compatibility in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.14 |
|
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debjyoti-pandit, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 7a07e8e
into
red-hat-storage:master
|
@SanjalKatiyar: new pull request created: #968 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@SanjalKatiyar: new pull request created: #969 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2214023
when only zone is present
when only rack is present
just in case we have both of them
