Bug 2213552: Modified to a standard time format in DR pages #940
Conversation
Signed-off-by: Gowtham Shanmugasundaram <[email protected]>
|
/retitle Bug 2213552: Modified to a standard time format in DR pages |
openshift-ci
bot
changed the title
|
@GowthamShanmugam: This pull request references Bugzilla bug 2213552, which is valid. No validations were run on this bugRequesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@GowthamShanmugam I have a doubt here (no need to make any changes in this PR)... but everywhere in ODF and now MCO while formatting time we are considering it as UTC timezone, is that alright to always convert to UTC... cluster can be in other timezones as well... |
Yes, clusters can be deployed in different zones, To resolve this time format issue, OCP is following UTC as a common time zone. Everywhere on the list page, they are using local time to display but popover UTC is used as a common timezone. |
so if OCP is using local time for list page, it means we are doing it wrong in ODF ?? I think in ODF we always use UTC (for list as well as popover) right ?? |
OCP is using UTC + local time. LocalTime to display text and UTC as a tooltip popover text. I think the place we can't provide popover its is correct to use UTC. |
I meant in ODF/MCO list pages as well we are using UTC instead of local time... anyway that's not related to this PR... |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GowthamShanmugam, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 291c1b3
into
red-hat-storage:master
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2213552