Page loader for DR policy list page and create policy page #937

GowthamShanmugam · 2023-07-26T09:29:26Z

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2212931

openshift-ci · 2023-07-26T09:29:37Z

@GowthamShanmugam: This pull request references Bugzilla bug 2212931, which is valid.

No validations were run on this bug

Requesting review from QA contact:
/cc @PrasadDesala

In response to this:

Bug 2212931: Page loader for delay in fetching cluster names or DRPolicy related details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-07-26T09:29:39Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@GowthamShanmugam: This pull request references Bugzilla bug 2212931, which is valid.

No validations were run on this bug

Requesting review from QA contact:
/cc @PrasadDesala

In response to this:

Bug 2212931: Page loader for delay in fetching cluster names or DRPolicy related details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GowthamShanmugam · 2023-07-26T10:17:34Z

Screencast.from.2023-07-26.15-42-33.webm

GowthamShanmugam · 2023-07-26T10:18:33Z

Screencast.from.2023-07-26.15-41-17.webm

SanjalKatiyar · 2023-07-27T07:17:29Z

packages/mco/components/disaster-recovery/drpolicy-list-page/drpolicy-list-page.tsx

        <EmptyPage
          title={t('No disaster recovery policies yet')}
          buttonText={t('Create DRPolicy')}
          canAccess={!drPoliciesLoadError && drPoliciesLoaded}
          t={t}
+          isLoaded={drPoliciesLoaded || !!drPoliciesLoadError}


don't u mean this ?? or in case of any error u are assuming it to be as loaded ??

Suggested change

isLoaded={drPoliciesLoaded || !!drPoliciesLoadError}

isLoaded={drPoliciesLoaded && !drPoliciesLoadError}

in case of any error u are assuming it to be as loaded ?? >> if so, then what will happen in case of any error, what will appear on screen ??

drPoliciesLoadError
Yes, I think both conditions are similar, But I will change to drPoliciesLoaded && !drPoliciesLoadError.
In case of an error, Just like ACM pages, The Empty page will disable the create DRPolicy button and display a default permission denied message over the button.

I tested, drPoliciesLoaded && !drPoliciesLoadError won't work when any user comes with DRPolicy read permission, it leads to keep loading. In that case, drPoliciesLoaded is always false and drPoliciesLoadError has permission-related errors.

ack... can u plz add a comment for the reason of doing this...

GowthamShanmugam · 2023-07-27T09:56:55Z

/hold adding unit testing

GowthamShanmugam · 2023-08-03T13:18:27Z

/hold cancel

SanjalKatiyar · 2023-08-08T05:28:54Z

packages/mco/components/empty-state-page/empty-page.tsx

@@ -43,13 +49,15 @@ const EmptyPage: React.FC<EmptyPageProps> = (props) => {
          }
          trigger={!canAccess ? 'mouseenter' : 'manual'}
          data-test="authorization-tooltip"
+          aria-label="Not Authorized"


Suggested change

aria-label="Not Authorized"

aria-label=t('Not Authorized')

Do we really need to translate aria-label?

ok, it looks like most of the places in odf-console is translating aria-label

SanjalKatiyar · 2023-08-08T05:28:55Z

packages/mco/components/empty-state-page/empty-page.tsx

+  return !isLoaded ? (
+    <div
+      className="loading-skeleton--table mco-empty-page__skeleton"
+      aria-label="Loading Empty Page"


Suggested change

aria-label="Loading Empty Page"

aria-label=t('Loading Empty Page')

SanjalKatiyar · 2023-08-08T05:29:09Z

packages/mco/components/empty-state-page/empty-page.tsx

        >
          {
            <Button
              variant="primary"
              onClick={onClick}
              isAriaDisabled={!canAccess}
              data-test="create-button"
+              aria-label="Create DRPolicy"


Suggested change

aria-label="Create DRPolicy"

aria-label=t('Create DRPolicy')

SanjalKatiyar · 2023-08-08T05:30:03Z

minor comments @GowthamShanmugam... LGTM...

…etails Signed-off-by: Gowtham Shanmugasundaram <[email protected]>

openshift-ci · 2023-08-08T11:12:39Z

@GowthamShanmugam: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Page loader for DR policy list page and create policy page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GowthamShanmugam · 2023-08-08T11:12:39Z

/cherry-pick release-4.14

openshift-cherrypick-robot · 2023-08-08T11:12:41Z

@GowthamShanmugam: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GowthamShanmugam · 2023-08-08T11:12:54Z

/bugzilla refresh

openshift-ci · 2023-08-08T11:12:56Z

@GowthamShanmugam: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GowthamShanmugam · 2023-08-08T11:27:40Z

/cherry-pick release-4.14-compatibility

openshift-cherrypick-robot · 2023-08-08T11:27:41Z

@GowthamShanmugam: once the present PR merges, I will cherry-pick it on top of release-4.14-compatibility in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GowthamShanmugam · 2023-08-08T11:28:05Z

@SanjalKatiyar Changes done

SanjalKatiyar · 2023-08-09T06:25:30Z

/approve
/lgtm

openshift-ci · 2023-08-09T06:25:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GowthamShanmugam, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [SanjalKatiyar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-cherrypick-robot · 2023-08-09T09:54:15Z

@GowthamShanmugam: new pull request created: #960

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-08-09T09:54:53Z

@GowthamShanmugam: new pull request created: #961

In response to this:

/cherry-pick release-4.14-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-low bugzilla/valid-bug labels Jul 26, 2023

GowthamShanmugam force-pushed the 2212931 branch 2 times, most recently from 87d0762 to c6d2441 Compare July 26, 2023 10:16

SanjalKatiyar reviewed Jul 27, 2023

View reviewed changes

GowthamShanmugam force-pushed the 2212931 branch 2 times, most recently from 76a35d4 to d84c4b1 Compare July 27, 2023 09:23

openshift-ci bot added the do-not-merge/hold label Jul 27, 2023

GowthamShanmugam force-pushed the 2212931 branch 2 times, most recently from bc53cf8 to 442d26e Compare August 3, 2023 13:17

openshift-ci bot removed the do-not-merge/hold label Aug 3, 2023

GowthamShanmugam force-pushed the 2212931 branch from 442d26e to 05119a0 Compare August 3, 2023 15:10

GowthamShanmugam changed the title ~~Bug 2212931: Page loader for delay in fetching cluster names or DRPolicy related details~~ Bug 2212931: Page loader DR policy list page and create policy page Aug 3, 2023

GowthamShanmugam changed the title ~~Bug 2212931: Page loader DR policy list page and create policy page~~ Bug 2212931: Page loader DR for policy list page and create policy page Aug 3, 2023

GowthamShanmugam changed the title ~~Bug 2212931: Page loader DR for policy list page and create policy page~~ Bug 2212931: Page loader for DR policy list page and create policy page Aug 3, 2023

GowthamShanmugam force-pushed the 2212931 branch from 05119a0 to 5107dd8 Compare August 3, 2023 15:48

SanjalKatiyar reviewed Aug 8, 2023

View reviewed changes

Page loader for delay in fetching cluster names or DRPolicy related d…

3fca811

…etails Signed-off-by: Gowtham Shanmugasundaram <[email protected]>

GowthamShanmugam force-pushed the 2212931 branch from 5107dd8 to 3fca811 Compare August 8, 2023 10:04

GowthamShanmugam changed the title ~~Bug 2212931: Page loader for DR policy list page and create policy page~~ Page loader for DR policy list page and create policy page Aug 8, 2023

openshift-ci bot removed the bugzilla/severity-low label Aug 8, 2023

openshift-ci bot removed the bugzilla/valid-bug label Aug 8, 2023

openshift-ci bot assigned SanjalKatiyar Aug 9, 2023

openshift-ci bot added the lgtm label Aug 9, 2023

openshift-ci bot added the approved label Aug 9, 2023

openshift-merge-robot merged commit 1d4675d into red-hat-storage:master Aug 9, 2023
3 checks passed

openshift-cherrypick-robot mentioned this pull request Aug 9, 2023

Bug 2212931: [release-4.14] Page loader for DR policy list page and create policy page #960

Merged

openshift-cherrypick-robot mentioned this pull request Aug 9, 2023

Bug 2212931: [release-4.14-compatibility] Page loader for DR policy list page and create policy page #961

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Page loader for DR policy list page and create policy page #937

Page loader for DR policy list page and create policy page #937

GowthamShanmugam commented Jul 26, 2023

openshift-ci bot commented Jul 26, 2023

openshift-ci bot commented Jul 26, 2023

GowthamShanmugam commented Jul 26, 2023 •

edited

Loading

GowthamShanmugam commented Jul 26, 2023

SanjalKatiyar Jul 27, 2023

SanjalKatiyar Jul 27, 2023

GowthamShanmugam Jul 27, 2023 •

edited

Loading

GowthamShanmugam Jul 27, 2023

SanjalKatiyar Jul 27, 2023

GowthamShanmugam Aug 8, 2023

GowthamShanmugam commented Jul 27, 2023

GowthamShanmugam commented Aug 3, 2023

SanjalKatiyar Aug 8, 2023

GowthamShanmugam Aug 8, 2023

GowthamShanmugam Aug 8, 2023

SanjalKatiyar Aug 8, 2023

SanjalKatiyar Aug 8, 2023

SanjalKatiyar commented Aug 8, 2023

openshift-ci bot commented Aug 8, 2023

GowthamShanmugam commented Aug 8, 2023

openshift-cherrypick-robot commented Aug 8, 2023

GowthamShanmugam commented Aug 8, 2023

openshift-ci bot commented Aug 8, 2023

GowthamShanmugam commented Aug 8, 2023

openshift-cherrypick-robot commented Aug 8, 2023

GowthamShanmugam commented Aug 8, 2023

SanjalKatiyar commented Aug 9, 2023

openshift-ci bot commented Aug 9, 2023

openshift-cherrypick-robot commented Aug 9, 2023

openshift-cherrypick-robot commented Aug 9, 2023

	isLoaded={drPoliciesLoaded \|\| !!drPoliciesLoadError}
	isLoaded={drPoliciesLoaded && !drPoliciesLoadError}

	aria-label="Loading Empty Page"
	aria-label=t('Loading Empty Page')

Page loader for DR policy list page and create policy page #937

Page loader for DR policy list page and create policy page #937

Conversation

GowthamShanmugam commented Jul 26, 2023

openshift-ci bot commented Jul 26, 2023

openshift-ci bot commented Jul 26, 2023

GowthamShanmugam commented Jul 26, 2023 • edited Loading

GowthamShanmugam commented Jul 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GowthamShanmugam Jul 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GowthamShanmugam commented Jul 27, 2023

GowthamShanmugam commented Aug 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjalKatiyar commented Aug 8, 2023

openshift-ci bot commented Aug 8, 2023

GowthamShanmugam commented Aug 8, 2023

openshift-cherrypick-robot commented Aug 8, 2023

GowthamShanmugam commented Aug 8, 2023

openshift-ci bot commented Aug 8, 2023

GowthamShanmugam commented Aug 8, 2023

openshift-cherrypick-robot commented Aug 8, 2023

GowthamShanmugam commented Aug 8, 2023

SanjalKatiyar commented Aug 9, 2023

openshift-ci bot commented Aug 9, 2023

openshift-cherrypick-robot commented Aug 9, 2023

openshift-cherrypick-robot commented Aug 9, 2023

GowthamShanmugam commented Jul 26, 2023 •

edited

Loading

GowthamShanmugam Jul 27, 2023 •

edited

Loading