Write e2e tests for Compression #479

bipuladh · 2022-10-10T12:53:01Z

Signed-off-by: Bipul Adhikari [email protected]

openshift-ci · 2022-10-10T12:53:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SanjalKatiyar · 2022-10-10T15:20:09Z

cypress/support.ts

+  // wait for the pod CR to be registered
+  // eslint-disable-next-line cypress/no-unnecessary-waiting
+  cy.wait(2500);
+  cy.exec(
+    `oc wait --for=condition=ready pod -l "app=rook-ceph-tools" -n openshift-storage`
+  );


can we use "commandPoll" here with "oc get pod -l 'app=rook-ceph-tools' ..." ??
cy.wait can cause extra waiting (if pod gets created before 2500 ms) or can cause flake (if take more than 2500 ms)...
using "commandPoll" we do have more network calls, but IMO it is okay as we are not affecting performance of our product, just adding few more network calls in our CI...

or if "commandPoll" won't work,
can we have some utility function similar to "commandPoll", which will continuously poll for a resource to check if it gets created or not instead of explicitly using cy.wait ??

we are not waiting for pod to get created. we are waiting for the CR to get registered as mentioned in the comment.

isn't CR will get created if it is registered ?
so if CR exists it means it got created/registered...

There is a difference between a pod getting created which involves multiple steps such as container creation, image pulling, volume mounting etc. versus just creation of a pod CR. Currently the cy.wait is only to wait for the CR to be registered in the kube-apiserver once that does we are waiting using the oc wait command for the pod to actually come up(get ready); this approach is better than commandPoll as commandPoll continuously pings the api-server(similar to ddos attack) instead of that we are simply adding a watcher(internally supported by k8s) it will also not fail after 30 retries as compared to commandPoll.

so what I meant was, check for CR created or not... status of CR can still be creating/running etc... anything...
if CR exists, it ensures that it is registered as well... so instead of cy.wait (and always waiting for 2500 ms for it to registered) we can use some function to do this job similar to "commandPoll" (not necessarily same function)... that will ensure that resource exists (not worry about status) before moving forwards will further...

cypress/tests/compression.spec.ts

SanjalKatiyar · 2022-10-10T15:49:14Z

cypress/tests/compression.spec.ts

+    // Allow job CR to be registered
+    // eslint-disable-next-line cypress/no-unnecessary-waiting
+    cy.wait(2500);


can we have some utility function like "commandPoll", which will continuously poll for a resource to check if it gets created or not instead of explicitly using cy.wait ??

As mentioned above we are not waiting for a resource to get created but for the CR to be registered. we could reduce it to 1000ms(1s) that should also work.

SanjalKatiyar · 2022-10-11T10:46:23Z

cypress/views/block-pool.ts

-  cy.byLegacyTestID('horizontal-link-Storage Systems').click();
+  cy.byTestID('horizontal-link-Storage Systems').click();


on my local, I can still see attribute as "data-test-id" only. Same is true for other tests as well, they are using "byLegacyTestID", just confirming if it is intentional change or a miss ?

SanjalKatiyar · 2022-10-11T10:47:05Z

cypress/views/block-pool.ts

@@ -20,7 +20,7 @@ export const poolMessage: {

 export const navigateToBlockPool = () => {
  ODFCommon.visitStorageDashboard();
-  cy.byLegacyTestID('horizontal-link-Storage Systems').click();
+  cy.byTestID('horizontal-link-Storage Systems').click();
  cy.byLegacyTestID('item-filter').type('ocs-storagecluster-storagesystem');
  cy.byTestRows('resource-row').get('td a').first().click();
  cy.byLegacyTestID('horizontal-link-BlockPools').click();


this is "data-test" instead...

bipuladh · 2022-10-17T07:00:21Z

/test odf-console-e2e-aws

bipuladh · 2022-10-17T07:55:36Z

/test odf-console-e2e-aws

bipuladh · 2022-10-17T09:41:36Z

/test odf-console-e2e-aws

bipuladh · 2022-10-17T10:43:15Z

/test odf-console-e2e-aws

bipuladh · 2022-10-17T11:55:29Z

/test odf-console-e2e-aws

bipuladh · 2022-10-18T03:29:55Z

/test odf-console-e2e-aws

bipuladh · 2022-11-14T02:33:48Z

/test odf-console-e2e-aws

bipuladh · 2022-11-17T06:43:19Z

/test odf-console-e2e-aws

bipuladh · 2022-11-23T10:51:16Z

/test odf-console-e2e-aws

bipuladh · 2022-11-30T12:55:36Z

/test odf-console-e2e-aws

bipuladh · 2022-12-01T10:25:09Z

/test odf-console-e2e-aws

bipuladh · 2022-12-07T11:01:28Z

/test odf-console-e2e-aws

bipuladh · 2023-03-20T07:29:28Z

/test odf-console-e2e-aws

SanjalKatiyar · 2023-10-17T08:10:12Z

/test odf-console-e2e-aws

bipuladh · 2024-03-19T10:33:13Z

/test odf-console-e2e-aws

bipuladh · 2024-03-19T10:33:39Z

/retest all

openshift-ci · 2024-03-19T10:33:43Z

@bipuladh: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test images
/test odf-console-e2e-aws

Use /test all to run all jobs.

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2024-03-19T10:33:54Z

/test all

Signed-off-by: Bipul Adhikari <[email protected]>

openshift-ci · 2024-04-16T09:34:30Z

@bipuladh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/odf-console-e2e-aws	`45719de`	link	true	`/test odf-console-e2e-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress label Oct 10, 2022

openshift-ci bot added the approved label Oct 10, 2022

bipuladh force-pushed the e2e-compression branch from 5de8a80 to 75103e0 Compare October 10, 2022 13:41

bipuladh changed the title ~~[wip] Write e2e tests for Compression~~ Write e2e tests for Compression Oct 10, 2022

openshift-ci bot removed the do-not-merge/work-in-progress label Oct 10, 2022

bipuladh force-pushed the e2e-compression branch 2 times, most recently from c2fd79c to 84c4783 Compare October 10, 2022 13:43

SanjalKatiyar reviewed Oct 10, 2022

View reviewed changes

cypress/tests/compression.spec.ts Show resolved Hide resolved

SanjalKatiyar reviewed Oct 10, 2022

View reviewed changes

cypress/tests/compression.spec.ts Show resolved Hide resolved

SanjalKatiyar reviewed Oct 10, 2022

View reviewed changes

bipuladh force-pushed the e2e-compression branch from 84c4783 to f661102 Compare October 11, 2022 08:11

SanjalKatiyar reviewed Oct 11, 2022

View reviewed changes

bipuladh force-pushed the e2e-compression branch from f661102 to 1f09ca1 Compare October 12, 2022 06:43

openshift-merge-robot added the needs-rebase label Oct 12, 2022

bipuladh force-pushed the e2e-compression branch from 1f09ca1 to 44bbd19 Compare October 12, 2022 07:54

openshift-merge-robot removed the needs-rebase label Oct 12, 2022

bipuladh force-pushed the e2e-compression branch 2 times, most recently from 471ce95 to 927e888 Compare October 17, 2022 05:35

bipuladh force-pushed the e2e-compression branch from 927e888 to 7f8d469 Compare October 18, 2022 06:35

bipuladh force-pushed the e2e-compression branch from 7f8d469 to c281a9a Compare November 17, 2022 12:40

openshift-merge-robot added the needs-rebase label Jun 22, 2023

bipuladh force-pushed the e2e-compression branch from c281a9a to 32ba4e5 Compare August 24, 2023 14:50

openshift-merge-robot removed the needs-rebase label Aug 24, 2023

Write e2e tests for Compression

edd482e

Signed-off-by: Bipul Adhikari <[email protected]>

bipuladh force-pushed the e2e-compression branch from 9f8d980 to edd482e Compare April 15, 2024 09:06

Merge branch 'master' into e2e-compression

45719de

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Write e2e tests for Compression #479

Write e2e tests for Compression #479

bipuladh commented Oct 10, 2022

openshift-ci bot commented Oct 10, 2022

SanjalKatiyar Oct 10, 2022 •

edited

Loading

SanjalKatiyar Oct 10, 2022

bipuladh Oct 10, 2022

SanjalKatiyar Oct 10, 2022 •

edited

Loading

bipuladh Oct 10, 2022

SanjalKatiyar Oct 10, 2022

SanjalKatiyar Oct 10, 2022

bipuladh Oct 10, 2022

SanjalKatiyar Oct 11, 2022

SanjalKatiyar Oct 11, 2022

bipuladh commented Oct 17, 2022

bipuladh commented Oct 17, 2022

bipuladh commented Oct 17, 2022

bipuladh commented Oct 17, 2022

bipuladh commented Oct 17, 2022

bipuladh commented Oct 18, 2022

bipuladh commented Nov 14, 2022

bipuladh commented Nov 17, 2022

bipuladh commented Nov 23, 2022

bipuladh commented Nov 30, 2022

bipuladh commented Dec 1, 2022

bipuladh commented Dec 7, 2022

bipuladh commented Mar 20, 2023

SanjalKatiyar commented Oct 17, 2023

bipuladh commented Mar 19, 2024

bipuladh commented Mar 19, 2024

openshift-ci bot commented Mar 19, 2024

bipuladh commented Mar 19, 2024

openshift-ci bot commented Apr 16, 2024

		cy.byLegacyTestID('horizontal-link-Storage Systems').click();
		cy.byTestID('horizontal-link-Storage Systems').click();

Write e2e tests for Compression #479

Are you sure you want to change the base?

Write e2e tests for Compression #479

Conversation

bipuladh commented Oct 10, 2022

openshift-ci bot commented Oct 10, 2022

SanjalKatiyar Oct 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjalKatiyar Oct 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bipuladh commented Oct 17, 2022

bipuladh commented Oct 17, 2022

bipuladh commented Oct 17, 2022

bipuladh commented Oct 17, 2022

bipuladh commented Oct 17, 2022

bipuladh commented Oct 18, 2022

bipuladh commented Nov 14, 2022

bipuladh commented Nov 17, 2022

bipuladh commented Nov 23, 2022

bipuladh commented Nov 30, 2022

bipuladh commented Dec 1, 2022

bipuladh commented Dec 7, 2022

bipuladh commented Mar 20, 2023

SanjalKatiyar commented Oct 17, 2023

bipuladh commented Mar 19, 2024

bipuladh commented Mar 19, 2024

openshift-ci bot commented Mar 19, 2024

bipuladh commented Mar 19, 2024

openshift-ci bot commented Apr 16, 2024

SanjalKatiyar Oct 10, 2022 •

edited

Loading

SanjalKatiyar Oct 10, 2022 •

edited

Loading