Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CA issue prerequisites #1673

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add CA issue prerequisites #1673

merged 1 commit into from
Nov 13, 2024

Conversation

SanjalKatiyar
Copy link
Collaborator

@SanjalKatiyar SanjalKatiyar commented Nov 12, 2024 •
edited
Loading

alfonsomthd
alfonsomthd reviewed Nov 12, 2024
View reviewed changes
packages/odf/components/s3-browser/ca-error/CAErrorMessage.tsx Outdated
Comment on lines 54 to 55
<br />
<br />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using several <br>, what about wrapping those phrases with <p> elements? Or using CSS margin?

Copy link
Collaborator Author

@SanjalKatiyar SanjalKatiyar Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either is fine by me, any particular reason for not using <br> (given it's just couple of them) ?? I can update the PR if so...

Copy link
Collaborator

@alfonsomthd alfonsomthd Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a best practice to use <br> for adding space between paragraphs: it's meant to add a line break and nothing else.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated...

@alfonsomthd
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 12, 2024
@SanjalKatiyar
Copy link
Collaborator Author

/test odf-console-e2e-aws

3 similar comments
@SanjalKatiyar
Copy link
Collaborator Author

/test odf-console-e2e-aws

@SanjalKatiyar
Copy link
Collaborator Author

/test odf-console-e2e-aws

@SanjalKatiyar
Copy link
Collaborator Author

/test odf-console-e2e-aws

@openshift-ci openshift-ci bot removed the lgtm label Nov 12, 2024
@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alfonsomthd, bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,alfonsomthd,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SanjalKatiyar
Copy link
Collaborator Author

/test odf-console-e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit ed2aab4 into red-hat-storage:master Nov 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd left review comments

Assignees

@alfonsomthd alfonsomthd

@bipuladh bipuladh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SanjalKatiyar @alfonsomthd @bipuladh