Adds column for quota utilization in client list page #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bipuladh
force-pushed
the
client-alert
branch
3 times, most recently
from
c8ce31c
to
146ecba
Compare
Signed-off-by: Bipul Adhikari <[email protected]>
bipuladh
force-pushed
the
client-alert
branch
from
146ecba
to
415fe91
Compare
| @@ -216,6 +225,9 @@ const ClientsList: React.FC<ClientListProps> = (props) => { | |||
| const getOpenshiftVersion = (obj: StorageConsumerKind) => | |||
| obj?.status?.client?.platformVersion; | |||
|
|
|||
| const getStorageQuotaUtilizationRatio = (obj: StorageConsumerKind) => | |||
| `${obj?.status?.client?.storageQuotaUtilizationRatio}`; | |||
There was a problem hiding this comment.
Suggested change
| `${obj?.status?.client?.storageQuotaUtilizationRatio}`; | |
| obj?.status?.client?.storageQuotaUtilizationRatio; |
There was a problem hiding this comment.
It needs to be string or JSX.Element number is neither
|
@bipuladh can u plz add the Jira link to the PR description ? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d61b5ce
into
red-hat-storage:master
5 checks passed
alfonsomthd
reviewed
Nov 12, 2024
| @@ -171,6 +175,11 @@ const ClientsList: React.FC<ClientListProps> = (props) => { | |||
| column.sort = 'status.storageQuotaInGiB'; | |||
| column.props.info = { popover: <StorageQuotaPopoverContent /> }; | |||
| break; | |||
| case 'storageQuotaUtilRation': | |||
There was a problem hiding this comment.
@bipuladh it should be storageQuotaUtilRatio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/RHSTOR-6481