Upgrade webpack-dev-server and webpack-cli dependencies #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanjalKatiyar
force-pushed
the
upgrade_webpack_deps
branch
from
2b9fb96
to
e11ec2a
Compare
SanjalKatiyar
commented
Nov 7, 2024
| @@ -179,14 +179,13 @@ | |||
| "stylelint-config-sass-guidelines": "^8.0.0", | |||
| "stylelint-config-standard": "^22.0.0", | |||
| "stylelint-order": "^4.1.0", | |||
| "webpack-dev-server": "^4.15.2" | |||
| "webpack-dev-server": "^5.1.0" | |||
| }, | |||
| "resolutions": { | |||
| "jest-environment-jsdom/jsdom": "^20.0.3", | |||
| "webpack": "5.94.0", | |||
| "webpack-bundle-analyzer/ws": "^7.5.10", | |||
| "webpack-dev-server/express": "^4.21.0", | |||
There was a problem hiding this comment.
latest webpack-dev-server still using "express": "^4.19.2",
There was a problem hiding this comment.
alfonsomthd
reviewed
Nov 7, 2024
package.json
Outdated
| @@ -126,7 +126,7 @@ | |||
| "victory-core": "^35.4.4", | |||
| "webpack": "5.94.0", | |||
| "webpack-bundle-analyzer": "^4.10.2", | |||
| "webpack-cli": "4.5.x", | |||
| "webpack-cli": "5.1.4", | |||
There was a problem hiding this comment.
@SanjalKatiyar provided we have a yarn.lock IMHO it's harmless to add the caret (^5.1.4) so when we run in the future yarn upgrade this package also gets upgraded (same for webpack package).
|
/lgtm |
SanjalKatiyar
force-pushed
the
upgrade_webpack_deps
branch
from
e11ec2a
to
ac939b1
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alfonsomthd, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f2db8df
into
red-hat-storage:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHSTOR-6588