Empty and Delete bucket modals #1652

weirdwiz · 2024-10-24T14:33:53Z

https://issues.redhat.com/browse/RHSTOR-6361

alfonsomthd · 2024-10-25T08:40:22Z

@weirdwiz You need to update translations.

packages/odf/components/s3-browser/bucket-overview/BucketOverview.tsx

packages/odf/modals/s3-browser/delete-buckets/DeleteBucketModal.tsx

packages/odf/modals/s3-browser/delete-buckets/EmptyBucketModal.tsx

packages/shared/src/s3/types.ts

packages/shared/src/s3/commands.ts

SanjalKatiyar · 2024-10-25T09:45:51Z

packages/odf/components/s3-browser/bucket-overview/BucketOverview.tsx

+    onClick: () =>
+      launcher(LazyDeleteBucketModal, {
+        isOpen: true,
+        extraProps: { bucketName, noobaaS3, launcher, refreshTokens },


Suggested change

extraProps: { bucketName, noobaaS3, launcher, refreshTokens },

extraProps: { bucketName, noobaaS3, launcher },

SanjalKatiyar · 2024-10-25T09:47:42Z

packages/odf/components/s3-browser/bucket-overview/BucketOverview.tsx

@@ -99,7 +124,6 @@ const BucketOverview: React.FC<{}> = () => {

  const { bucketName } = useParams();
  const [searchParams] = useSearchParams();
-


nits: space was here to separate hooks call from normal variable...

packages/odf/components/s3-browser/bucket-overview/BucketOverview.tsx

locales/en/plugin__odf-console.json

packages/odf/modals/s3-browser/delete-and-empty-bucket/DeleteBucketModal.tsx

SanjalKatiyar · 2024-11-13T18:42:43Z

packages/odf/components/s3-browser/bucket-overview/BucketOverview.tsx

@@ -151,7 +189,7 @@ const BucketOverview: React.FC<{}> = () => {
      : []),
  ];

-  const actions = () => {
+  const actions = (noobaaS3: S3Commands) => () => {


plz fix linter issues reported by GH actions...

packages/odf/components/s3-browser/buckets-list-page/bucketListTable.tsx

packages/odf/modals/s3-browser/delete-and-empty-bucket/EmptyBucketModal.tsx

SanjalKatiyar · 2024-11-14T05:37:56Z

packages/odf/modals/s3-browser/delete-and-empty-bucket/DeleteBucketModal.tsx

+      {error ||
+        (deleteError && (
+          <Alert
+            variant={AlertVariant.danger}
+            isInline
+            title={t('Error')}
+            className="pf-v5-u-mt-md"
+          >
+            {error?.message || deleteError?.message}
+          </Alert>
+        ))}


Suggested change

{error ||

(deleteError && (

<Alert

variant={AlertVariant.danger}

isInline

title={t('Error')}

className="pf-v5-u-mt-md"

>

{error?.message || deleteError?.message}

</Alert>

))}

{(error || deleteError) && (

<Alert

variant={AlertVariant.danger}

isInline

title={t('Error')}

className="pf-v5-u-mt-md"

>

{error?.message || deleteError?.message}

</Alert>

)}

SanjalKatiyar · 2024-11-14T06:03:59Z

/approve
/lgtm

- Add Delete Bucket modal for bucket removal - Add Empty Bucket modal for clearing bucket contents - Implement success/failure alerts for operations - Handle S3 API responses Signed-off-by: Divyansh Kamboj <[email protected]>

SanjalKatiyar · 2024-11-14T06:52:18Z

/lgtm

openshift-ci · 2024-11-14T06:52:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SanjalKatiyar, weirdwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [SanjalKatiyar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SanjalKatiyar · 2024-11-14T08:27:13Z

/test odf-console-e2e-aws

alfonsomthd · 2024-11-14T10:32:57Z

/override ci/prow/odf-console-e2e-aws

openshift-ci · 2024-11-14T10:33:02Z

@alfonsomthd: Overrode contexts on behalf of alfonsomthd: ci/prow/odf-console-e2e-aws

In response to this:

/override ci/prow/odf-console-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

alfonsomthd reviewed Oct 25, 2024

View reviewed changes

packages/odf/components/s3-browser/bucket-overview/BucketOverview.tsx Outdated Show resolved Hide resolved