Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the kebab menu close when we click outside the kebab. #1595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the kebab menu close when we click outside the kebab. #1595

wants to merge 1 commit into from
+34 −6

Conversation

TimothyAsirJeyasing
Copy link
Contributor

@TimothyAsirJeyasing TimothyAsirJeyasing commented Sep 23, 2024 •
edited
Loading

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the fix-kabab-close-when-click-outside-bz2308314 branch from 8bfe4dc to ef4adc5 Compare November 11, 2024 14:27
@alfonsomthd
Copy link
Collaborator

LGTM. @SanjalKatiyar for tagging.

1 similar comment
@alfonsomthd
Copy link
Collaborator

LGTM. @SanjalKatiyar for tagging.

bipuladh
bipuladh approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SanjalKatiyar
Copy link
Collaborator

/lgtm cancel
small comment

@openshift-ci openshift-ci bot removed the lgtm label Nov 12, 2024
SanjalKatiyar
SanjalKatiyar reviewed Nov 12, 2024
View reviewed changes
packages/shared/src/kebab/kebab.tsx Outdated

const { resourceModel, resource } = extraProps;
// Use the custom hook to detect clicks outside the Kebab menu
useClickOutside(dropdownRef, () => setOpen(false));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u are passing callback () => setOpen(false) to dep list of useEffect inside useClickOutside hook, but ref of this callback is changing on each re-render.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap it around useCallback plz...

@SanjalKatiyar
Copy link
Collaborator

@TimothyAsirJeyasing plz add corresponding Jira BZ link to this PR...

@alfonsomthd
Copy link
Collaborator

@TimothyAsirJeyasing please rebase & solve conflicts.

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the fix-kabab-close-when-click-outside-bz2308314 branch from ef4adc5 to 54ce4b0 Compare November 14, 2024 15:24
@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the fix-kabab-close-when-click-outside-bz2308314 branch from 54ce4b0 to d9697d4 Compare November 14, 2024 17:40
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the fix-kabab-close-when-click-outside-bz2308314 branch from d9697d4 to 3626987 Compare November 14, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjalKatiyar SanjalKatiyar SanjalKatiyar left review comments

@alfonsomthd alfonsomthd alfonsomthd left review comments

@bipuladh bipuladh bipuladh approved these changes

Assignees

@SanjalKatiyar SanjalKatiyar

@bipuladh bipuladh

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TimothyAsirJeyasing @alfonsomthd @SanjalKatiyar @bipuladh @openshift-merge-robot