Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 4 new test cases and a support for nss creation for gcp platform #11599

Conversation

ypersky1980
Copy link
Contributor

This PR handles requirements specified in #11129 and there are 4 new test cases which were added:

CLI NSS creation over Azure
CLI NSS creation over IBMCOS
CLI NSS creation over AWS
CLI NSS creation over GCP
In order to support creation of NSS over GCP a support was added to namespacestore.py.

@ypersky1980 ypersky1980 requested review from a team as code owners March 11, 2025 07:22
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Mar 11, 2025
@ypersky1980
Copy link
Contributor Author

Please refer to this PR #11597 for validation of this PR ( 4 PASSED jobs) .

@sagihirshfeld
Copy link
Contributor

Please remove the newly added on_prem_platform_required marks since they will cause a skip of these tests when they shouldn't. This is only applicable for RGW-OC-Single and RGW-CLI-Single.

Signed-off-by: Yulia Persky <[email protected]>
@ypersky1980 ypersky1980 added MCG Multi Cloud Gateway / NooBaa related issues Squad/Red Verified Mark when PR was verified and log provided labels Mar 11, 2025
Copy link
Contributor

@sagihirshfeld sagihirshfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sagihirshfeld, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/M PR that changes 30-99 lines Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants