Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ceph full thresholds upgrade combinations #11589

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ceph full thresholds upgrade combinations #11589

wants to merge 2 commits into from
+88 −57

Conversation

petr-balogh
Copy link
Member

No description provided.

@petr-balogh petr-balogh requested a review from a team as a code owner March 10, 2025 09:06
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Mar 10, 2025
ebenahar
ebenahar previously approved these changes Mar 10, 2025
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Mar 10, 2025
@petr-balogh
Copy link
Member Author

petr-balogh commented Mar 10, 2025 •
edited
Loading

Verification:
https://url.corp.redhat.com/c825c28

Bad prams, continuing with upgrade here:
https://url.corp.redhat.com/7dc6fb9

OdedViner
OdedViner previously approved these changes Mar 10, 2025
View reviewed changes
@petr-balogh petr-balogh dismissed stale reviews from OdedViner and ebenahar via a6ffb7c March 10, 2025 17:37
@petr-balogh petr-balogh requested a review from a team as a code owner March 10, 2025 17:37
@openshift-ci openshift-ci bot removed the lgtm label Mar 10, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 10, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-balogh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-balogh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-balogh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-balogh
Copy link
Member Author

New verification:
https://jenkins-csb-odf-qe-ocs4.dno.corp.redhat.com/job/qe-deploy-ocs-cluster/47716/

@petr-balogh petr-balogh force-pushed the ceph-full-thresholds-upgrade-combination branch from a6ffb7c to 2bdcd53 Compare March 10, 2025 20:13
@petr-balogh
Copy link
Member Author

Another verification job:
https://url.corp.redhat.com/a14ee36

@petr-balogh petr-balogh force-pushed the ceph-full-thresholds-upgrade-combination branch from 2bdcd53 to 1e2c2ed Compare March 11, 2025 22:19
@petr-balogh
Copy link
Member Author

New verification:
https://url.corp.redhat.com/aadf335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebenahar ebenahar ebenahar left review comments

@OdedViner OdedViner OdedViner left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@ebenahar ebenahar

@OdedViner OdedViner

Labels
size/L PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petr-balogh @ebenahar @OdedViner