Adding kms policy name for same kms encryption keys #11497
Conversation
|
Verification job: https://jenkins-csb-odf-qe-ocs4.dno.corp.redhat.com/job/qe-rdr-setup/1655/ |
pull-request-size
bot
added
size/M
Signed-off-by: Shivam Durgbuns <[email protected]>
Signed-off-by: Shivam Durgbuns <[email protected]>
Signed-off-by: Shivam Durgbuns <[email protected]>
Signed-off-by: Shivam Durgbuns <[email protected]>
Signed-off-by: Shivam Durgbuns <[email protected]>
shivamdurgbuns
force-pushed
the
issue/11495
branch
from
1213ae1 to
7dd7b3a
Compare
|
Verification job here: https://jenkins-csb-odf-qe-ocs4.dno.corp.redhat.com/job/qe-rdr-setup/1667/ |
|
New validation: |
ocs_ci/utility/kms.py
Outdated
| @@ -129,7 +129,7 @@ def __init__(self): | |||
| "VAULT_BACKEND", defaults.VAULT_DEFAULT_BACKEND_VERSION | |||
| ) | |||
| self.kmsid = None | |||
| self.vault_policy_name = None | |||
| self.vault_policy_name = self.kms_vault_policy_name() | |||
There was a problem hiding this comment.
| self.vault_policy_name = self.kms_vault_policy_name() | |
| self.vault_policy_name = self.kms_vault_policy_name |
petr-balogh
dismissed
their stale review
There is an issue:
2025-03-05 12:12:01 > self.vault_policy_name = self.kms_vault_policy_name()
2025-03-05 12:12:01 E TypeError: 'str' object is not callable
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shivamdurgbuns The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Shivam Durgbuns <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
new vaildation job: https://jenkins-csb-odf-qe-ocs4.dno.corp.redhat.com/job/qe-rdr-setup/1680/ |
Fixes issue: #11495