Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guaranteed bucket logs tests #10805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sagihirshfeld
Copy link
Contributor

A small fix to ocs-ci/tests/functional/object/mcg/test_bucket_logs.py::TestBucketLogs::test_bucket_logs_integrity:

  • Fix the use of append to add on the expected_ops_set at BucketLoggingManager:verify_logs_integrity
  • Update the expectation for incoming logs to start with a forward-slash at test_bucket_logs_integrity

Signed-off-by: Sagi Hirshfeld <[email protected]>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-417ibm42
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_logs.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@sagihirshfeld sagihirshfeld added the Verified Mark when PR was verified and log provided label Nov 5, 2024
@sagihirshfeld sagihirshfeld marked this pull request as ready for review November 5, 2024 18:19
@sagihirshfeld sagihirshfeld requested review from a team as code owners November 5, 2024 18:19
Copy link

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, sagihirshfeld, udaysk23

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/XS Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants