Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from 5.16 for noobaa-operator #9

Closed
wants to merge 707 commits into from

Conversation

df-build-team
Copy link

PR containing the latest commits from 5.16 branch

shirady and others added 30 commits May 1, 2023 12:13
Co-authored-by: jackyalbo <[email protected]>
Signed-off-by: Alexander Indenbaum <[email protected]>
Master Root Key rotation for K8S secret backend
NooBaaBucketExceedingSizeQuotaState and
NooBaaBucketReachingQuantityQuotaState are missing in the
deployment and result which the alerts are not getting
triggered. Adding the above alert to this patch.

Ref Patch: noobaa/noobaa-mixins#23

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2154250
Signed-off-by: Vinayakswami Hariharmath <[email protected]>
ignore ReadSystemInfo persistent error in deletion
Fixing issue with operator log level
CI | Run `docker manifest inspect` With `sudo`
Aligning description for NooBaaBucketExceedingQuantityQuotaState
and NooBaaBucketReachingQuantityQuotaState with the description
in mixins

Signed-off-by: Vinayakswami Hariharmath <[email protected]>
This got introduced in https://github.com/noobaa/noobaa-operator/pull/1125/files
and removing it through this comment

Signed-off-by: Vinayakswami Hariharmath <[email protected]>
Remove unwanted character "\" from the description
… ) in diagnostics

that apply a job to test the resource

Signed-off-by: shirady <[email protected]>
fixing issue - setting externalDNS without port
Signed-off-by: nadav mizrahi <[email protected]>
Fix incorrect function ListAccountsAPI()
Signed-off-by: Danny Zaken <[email protected]>
Signed-off-by: jackyalbo <[email protected]>
Signed-off-by: Romy <[email protected]>
Neon-White and others added 26 commits April 8, 2024 10:19
* Add the CA-bundle injection configmap to the NooBaa package
- Revert Azure cert bundle injection
- Change the OCP injected CA bundle configmap name
- Change the CA bundle mountPath to not override system certs
- Change `AddToRootCAs` to append to the system pool instead of a new one
* Remove redundant newline
* Add missing `subPath`
* Fix `optional` indentation
* - Remove injectable configmap creation
- Generate `deploy.go`
- Fix old bundle path references
* Omit subPath usage since it doesn't update the file when the ConfigMap changes

https: //kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/#mounted-configmaps-are-updated-automatically

Signed-off-by: Ben <[email protected]>
Bumps [github.com/go-jose/go-jose/v3](https://github.com/go-jose/go-jose) from 3.0.1 to 3.0.3.
- [Release notes](https://github.com/go-jose/go-jose/releases)
- [Changelog](https://github.com/go-jose/go-jose/blob/v3.0.3/CHANGELOG.md)
- [Commits](go-jose/go-jose@v3.0.1...v3.0.3)

---
updated-dependencies:
- dependency-name: github.com/go-jose/go-jose/v3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…ub.com/go-jose/go-jose/v3-3.0.3

Bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3
Fix default resource request/limit for PV pool pods
The azure kms is expecting the secret to be present
at key azure.AzureClientCertPath. We were storing the
secret with wrong key which which was stopping azure kms
to read the secret the from expected key.

This patch handles the correction

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2275049
Signed-off-by: Vinayakswami Hariharmath <[email protected]>
Fixing AzureClientCertPath in kms for azure
To accommodate the above change we are moving k8s.io/api
to 0.29.3 which is effectively bringing VolumeResourceRequirements
in place of ResourceRequirements

PersistentVolumeClaimSpec has ResourceRequirements in 0.28.4 and here is the github link for the same
https://github.com/kubernetes/api/blob/d2d5db7d05d8a0c0dfc5e76035904476a065987c/core/v1/types.go#L489C12-L489C32

and the ResourceRequirements has been replaced by VolumeResourceRequirements in 0.29.3 and the github link is below
https://github.com/kubernetes/api/blob/a819b1d9bd169a0584c6d17430450ec1976c17de/core/v1/types.go#L502C12-L502C38

Since the change has happened inside PersistentVolumeClaimSpec in k8s.io/api, we can safely assume that updating to
0.29.3 from 0.28.4 wont break our code.

Few more details:

ResourceRequirements definition in 0.28.4
https://github.com/kubernetes/api/blob/d2d5db7d05d8a0c0dfc5e76035904476a065987c/core/v1/types.go#L2394

VolumeResourceRequirements definition in updated v0.29.3
https://github.com/kubernetes/api/blob/a819b1d9bd169a0584c6d17430450ec1976c17de/core/v1/types.go#L2608

Signed-off-by: Vinayakswami Hariharmath <[email protected]>
Updating Rook to v0.0.0-20240327231646-b6b89a012a95
Signed-off-by: Utkarsh Srivastava <[email protected]>

include pod agent change

Signed-off-by: Utkarsh Srivastava <[email protected]>

make gen-api

Signed-off-by: Utkarsh Srivastava <[email protected]>

update deploy.go

Signed-off-by: Utkarsh Srivastava <[email protected]>

address PR comments

Signed-off-by: Utkarsh Srivastava <[email protected]>
Fix printing of Identity

Signed-off-by: liranmauda <[email protected]>
* Added fsGroup 0 to the agent pod
* moved allowPrivilegeEscalation in the DB sts to the container security
  context

Signed-off-by: Danny Zaken <[email protected]>
Fix for mount permissions on the agents PV
Fixed AccessKeys printings on RPC calls

Signed-off-by: liranmauda <[email protected]>
…ntings

Fixed AccessKeys printings on RPC calls
Signed-off-by: Ameena Suhani S H <[email protected]>
Support user-provided NSFSAccountConfig when creating OBCs
Refactor LoadBucketReplicationJSON to a generic LoadConfigurationJSON function
Add CLI support for passing an NSFS configuration
Pass NsfsAccountConfig to CreateAccountAPI when creating a new OBC
Add NSFS account config validation
Add distinguished_name support
Convert NsfsAccountConfig's GID and UID properties to be pointers to support a 0-value without omitempty getting rid of them
Fix bug that wouldn't allow setting UID/GID to 0
Signed-off-by: Ben <[email protected]>
Added a CLI command to manually update account credentials (access key and secret key)
Fixed type casting for GenerateNonCrdAccountKeys
Bump dependencies

Signed-off-by: liranmauda <[email protected]>
@df-build-team df-build-team requested a review from a team June 19, 2024 05:25
Copy link

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: df-build-team

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nikhil-Ladha Nikhil-Ladha deleted the sync_ds--5.16 branch June 24, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.