Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product_version: add releasedBuild() support #250

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lxbsz
Copy link

@lxbsz lxbsz commented Feb 26, 2025

No description provided.

Copy link

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lxbsz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lxbsz lxbsz force-pushed the prodv branch 2 times, most recently from 9778549 to 822111c Compare February 27, 2025 05:31
Copy link

@ianw ianw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also add a test case in errata_tool/tests/test_product_version.py

product_version: add releasedBuild() support and allows to use name to get the released builds

I think the second part of this description is now not required

Copy link

openshift-ci bot commented Mar 3, 2025

@ianw: changing LGTM is restricted to collaborators

In response to this:

This should also add a test case in errata_tool/tests/test_product_version.py

product_version: add releasedBuild() support and allows to use name to get the released builds

I think the second part of this description is now not required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lxbsz lxbsz changed the title product_version: add releasedBuild() support and allows to use name to get the released builds product_version: add releasedBuild() support Mar 4, 2025
@lxbsz
Copy link
Author

lxbsz commented Mar 4, 2025

This should also add a test case in errata_tool/tests/test_product_version.py

Sure, will do it.

product_version: add releasedBuild() support and allows to use name to get the released builds

I think the second part of this description is now not required

Will remove it.

lxbsz added 2 commits March 4, 2025 15:53
Get the released build for a dedicated package of this Product Version.

Signed-off-by: Xiubo Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants