TFA fix to ignore bluestore slowness alert during health checks #4536
+93
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumabai
requested review from
neha-gangadhar,
AmarnatReddy and
Manimaran-MM
as code owners
|
Agree with the comment of moving it to a new lib. Otherwise LGTM |
sumabai
force-pushed
the
regression_pr
branch
5 times, most recently
from
2ec5109 to
31ffd65
Compare
sumabai
force-pushed
the
regression_pr
branch
4 times, most recently
from
1b4b6e2 to
98770ad
Compare
Signed-off-by: Suma R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JIRA: https://issues.redhat.com/browse/RHCEPHQE-18401
Fix description : In below scripts, there exists ceph health checks expecting status as HEALTH_OK, but in current squid 8.1 regression runs due to unavoidable bluestore slowness alerts, adding code to ignore this warning and proceed with execution.
Files:
modified: tests/cephfs/snapshot_clone/cg_snap_system_test.py
modified: tests/cephfs/snapshot_clone/cg_snap_test.py
modified: tests/cephfs/snapshot_clone/snap_schedule_retention_vol_subvol.py
Logs:
Latest logs with comments addressed:
http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-NN1ZI1/snap_sched_subvol_0.log
http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-LAHJPH/cg_snap_interop_workflow_2_0.log
http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-MJPVDX/cg_snap_interop_workflow_2_0.log
http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-XOIV5B/snap_sched_subvol_0.log
Please include Automation development guidelines. Source of Test case - New Feature/Regression Test/Close loop of customer BZs
click to expand checklist