Adding nvme gateway deploymnets to common config #4476
+336
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamahaja
requested changes
Feb 25, 2025
tintumathew10
force-pushed
the
nvme_simp
branch
2 times, most recently
from
b2b51a9 to
5d38c82
Compare
vamahaja
reviewed
Mar 6, 2025
suites/squid/common/regression/nvme-single-site-deploy-and-configure.yaml
Outdated
Show resolved
Hide resolved
|
logs - |
|
|
conf/squid/common/17node-4client-nvme-single-site-regression.yaml
Outdated
Show resolved
Hide resolved
conf/squid/common/17node-4client-nvme-single-site-regression.yaml
Outdated
Show resolved
Hide resolved
conf/squid/common/17node-4client-nvme-single-site-regression.yaml
Outdated
Show resolved
Hide resolved
conf/squid/common/17node-4client-nvme-single-site-regression.yaml
Outdated
Show resolved
Hide resolved
conf/squid/common/17node-4client-nvme-single-site-regression.yaml
Outdated
Show resolved
Hide resolved
suites/squid/common/regression/nvme-single-site-deploy-and-configure.yaml
Outdated
Show resolved
Hide resolved
suites/squid/common/regression/nvme-single-site-deploy-and-configure.yaml
Show resolved
Hide resolved
suites/squid/common/regression/nvme-single-site-deploy-and-configure.yaml
Outdated
Show resolved
Hide resolved
suites/squid/common/regression/nvme-single-site-deploy-and-configure.yaml
Show resolved
Hide resolved
suites/squid/common/regression/nvme-single-site-deploy-and-configure.yaml
Show resolved
Hide resolved
tintumathew10
force-pushed
the
nvme_simp
branch
2 times, most recently
from
d6068db to
c937b01
Compare
tintumathew10
requested review from
rahullepakshi,
sunilangadi2 and
AmarnatReddy
tintumathew10
force-pushed
the
nvme_simp
branch
from
c937b01 to
86a6bf3
Compare
Signed-off-by: tintumathew10 <[email protected]>
tintumathew10
force-pushed
the
nvme_simp
branch
from
86a6bf3 to
7d0ed25
Compare
| data_devices: | ||
| all: "true" | ||
| encrypted: "true" | ||
| - config: |
There was a problem hiding this comment.
I think this config step has to be removed
There was a problem hiding this comment.
@AmarnatReddy can you confirm?
sunilangadi2
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding nvme gateway deploymnets to common config