Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to PHPStan 2.1.9 #6806

Merged
merged 4 commits into from
Mar 23, 2025
Merged

Bump to PHPStan 2.1.9 #6806

merged 4 commits into from
Mar 23, 2025

Conversation

samsonasik
Copy link
Member

Bump to latest PHPStan 2.1.9 seems cause error in tests:

There were 2 errors:

1) Rector\Tests\Php55\Rector\String_\StringClassNameToClassConstantRector\StringClassNameToClassConstantRectorTest::test with data set #4 ('/Users/samsonasik/www/rector-...hp.inc')
PHPStan\Analyser\UndefinedVariableException: Undefined variable: $field1

phar:///Users/samsonasik/www/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php:427
phar:///Users/samsonasik/www/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php:1487
phar:///Users/samsonasik/www/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php:1487
phar:///Users/samsonasik/www/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php:554
phar:///Users/samsonasik/www/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php:1845
phar:///Users/samsonasik/www/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php:727
phar:///Users/samsonasik/www/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php:404
/Users/samsonasik/www/rector-src/src/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php:461
/Users/samsonasik/www/rector-src/src/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php:247

This PR try to resolve it.

@samsonasik samsonasik mentioned this pull request Mar 23, 2025
Merged
@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik samsonasik mentioned this pull request Mar 23, 2025
Closed
@samsonasik
Copy link
Member Author

I created PHPStan issue for it

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 18f9216 into main Mar 23, 2025
44 checks passed
@samsonasik samsonasik deleted the bump-phpstan-219 branch March 23, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @TomasVotruba @actions-user