[find-rule] Add Laravel sets and improve group select #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
commented
Aug 30, 2024
| 'Container strings to FQN types', | ||
| LaravelSetList::LARAVEL_CONTAINER_STRING_TO_FULLY_QUALIFIED_NAME, | ||
| ), | ||
| // @todo fill the rest |
There was a problem hiding this comment.
@peterfox Hey Peter, just to give you heads up, this is new way to provide sets for Rector internal/tools.
We've tested and used it for couple months now and I think it's time to use in community packages 👍
For e.g. this is how it look for Symfony: https://github.com/rectorphp/rector-symfony/blob/main/src/Set/SetProvider/SymfonySetProvider.php
Could I ask you for help to fill the rest of sets here? 🙏
There was a problem hiding this comment.
@TomasVotruba of course. I'll go through and PR this over the weekend. This looks great 👍
TomasVotruba
changed the title
Closed
TomasVotruba
force-pushed
the
tv-find-rules-laravel
branch
from
87e8edc
to
bc5f337
Compare
TomasVotruba
changed the title
|
Let's test the page online first. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.