Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.10 and 3.11 #1937
Add support for Python 3.10 and 3.11 #1937
Changes from 17 commits
ffac856
ffd8b9e
644aa5d
9003450
a157403
793ec87
1556eb4
34aee1d
890a3fe
c7bb846
7f2e298
09069f7
643fed6
db4c9c3
9e05e4f
e1d6acf
b71c4ed
3b4a641
3cb052a
d80002e
e084412
a605404
40361f4
9364c9b
be86a29
0641d95
334ea1a
60e847a
313de47
91be6ae
015ce4a
76901c6
22ac9e2
d0074c5
c3a7030
3149ae7
15fbf90
a7f8346
9f9c815
2fdf590
b2fef7a
9a225d5
5484d9b
6944404
0e69106
22ef9b9
a5fea78
dccac17
d3b0ad7
d249bfe
547ab66
ed3b632
c8d90f7
d9ec1cd
d59f7ec
fda5265
ac90e54
1d0fe7d
0740b16
89cc985
55433c5
730a5e9
657531a
e99b8d0
03554de
47281c8
19bcf1a
b255fae
85899cf
d8e8ac3
21492c9
14c5c93
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonzhaoms right now in the actions we are installing
run: pip install --quiet "azureml-core>1,<2" "azure-cli>2,<3"
. What is the azurml sdk that we are installing? Here I see the latest one as 1.51 https://pypi.org/project/azureml-sdk/#history.Of the 3 options, I think one that is interesting to explore would be
Try install everything in the docker file without using Conda.
iif we are reducing dependencies. I think 80% of our problems come from dependencies: #1936 So maybe something to reflect on is how can we reduce dependencies and use more standardize and robust software?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miguelgfierro
I think this
azureml-core
is only used for launching the scriptsubmit_groupwise_azureml_pytest.py
.https://github.com/microsoft/recommenders/blob/b71c4ed66991f8eddfd80a8afbff05b34591c7ee/.github/actions/azureml-test/action.yml#L75-L77
And the AzureML SDK I mentioned is used inside the docker image launched inside
submit_groupwise_azureml_pytest.py
https://github.com/microsoft/recommenders/blob/b71c4ed66991f8eddfd80a8afbff05b34591c7ee/.github/actions/azureml-test/action.yml#L85-L94
https://github.com/microsoft/recommenders/blob/b71c4ed66991f8eddfd80a8afbff05b34591c7ee/tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py#L178-L194
I think when we use
CondaDependencies.add_pip_package("xxx")
, AzureML adds the itemxxx
in a Conda env yaml file maintained by itself, and the AzureML SDK is also an item added by AzureML by default implicitly.https://github.com/microsoft/recommenders/blob/b71c4ed66991f8eddfd80a8afbff05b34591c7ee/tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py#L202-L223
What I don't know is why the AzureML SDK trigger the error now when I try to add support for Python 3.10 and upgrade all dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. In addition, if possible, I'd use what GitHub actions and workflows can provide to build the testing pipeline rather than use the AzureML service, because AzureML service is not transparent.